254894 - Menu automatically closes when using xmlhttprequest in an interval timer

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Martijn Wargers (dead)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a3) Gecko/20040808 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a3) Gecko/20040808 Firefox/0.9.1+

See upcoming testcase. I'm not sure in which component this bug should be.

This testcase causes the menu to close again (after 2 seconds which is the timer
interval of the script), after you have opened it.
It happens because of:
var req = new XMLHttpRequest();
req.open("GET", this.location.href,false);
req.send(null);


Reproducible: Always
Steps to Reproduce:
1. Load testcase
2. Open any menu with the mouse. 
3. Stay on the same position of where you clicked to open the menu

Actual Results:  
Menu closes automatically (max 2 seconds after clicking).

Expected Results:  
Should not close menu automatically.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Martijn Wargers (dead)]

Attachment: This one works

Aargh! the previous one was wrong. This one should show the bug.

Comment 3

[Martijn Wargers (dead)]

Probably related to all the
document-refresh-stealing-keyboard-focus-from-textbox issues.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Could pushing a new event queue somehow close the menu?

Comment 5

[[e-mail]]

This is a windows-only bug, according to my stack trace. Investigating...

Comment 6

[[e-mail]]

(In reply to comment #4)
> Could pushing a new event queue somehow close the menu?
It sure could. In Windows, creating an event queue creates a window, but the
widget code dismisses all popups whenever a window is moved, sized or created.

Comment 7

[[e-mail]]

So maybe we should only make the dismissal code work for visible windows?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Over to Windows widget...  We should do _something_, certainly; having event
queue pushing closing popups is no good.

Comment 9

[:deanis74]

(In reply to comment #7)
> So maybe we should only make the dismissal code work for visible windows?

That seems logical to me.

Comment 10

[:deanis74]

*** Bug 293741 has been marked as a duplicate of this bug. ***

Comment 11

[[e-mail]]

Attachment: Proposed patch

Comment 12

[:deanis74]

Comment on attachment 186874 [details] [diff] [review]
Proposed patch

Assuming it works, r=me.  Alternatively, couldn't we kill a level of braces by
changing this to:

if (!(gRollupListener && gRollupWidget && IsWindowVisible(inWnd)))
  return FALSE;

Or something similar?

Comment 13

[Darin Fisher]

Comment on attachment 186874 [details] [diff] [review]
Proposed patch

rs=darin

Comment 14

[[e-mail]]

Comment on attachment 186874 [details] [diff] [review]
Proposed patch

Trivial fix.

Comment 15

[[e-mail]]

Fix checked in.