Export Selected Events to ical format problems: multiple VCALENDAR, lines not \r\n terminated

RESOLVED FIXED

Status

RESOLVED FIXED
15 years ago
13 years ago

People

(Reporter: gekacheka, Assigned: mostafah)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

15 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.2) Gecko/20040803
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.2) Gecko/20040803, 20040809-cal

As reported in bug 179985, some programs expect only one VCALENDAR per file.
Bug 231724 reports programs having problems because exported lines are not
terminated with \r\n.

This bug is for these frontend problems in Exporting selected events. (The
backend patch discussed at bug 179985 doesn't affect exporting selected events,
the result of which is built up partly by the frontend.)



Reproducible: Always
Steps to Reproduce:
(Reporter)

Comment 1

15 years ago
Created attachment 155759 [details] [diff] [review]
importExport.js patch eventArrayToICalString: merge into one VCALENDAR, convert to \r\n

Patches eventArrayToICalString(eventArray, doPatchForExport) so
if doPatchForExport is true:
- If all events have same method, merges components into one VCALENDAR.
  (Times are Zulu/UTC, so no VTIMEZONEs expected, so no duplicate VTIMEZONES.)
- Converts line terminators to full \r\n as specified by RFC2445.

Also changes loop accumulation from copy-appending an ever-longer string, to
collecting an array of strings and joining them once at the end of the loop.

[also adds a 
   "gICalLib" in opener &&
test before accessing 
   opener.gICalLib 
to avoid a strict javascript warning.]

Tested with 20040809-cal on Mozilla 1.7.2, Mozilla 1.8a2, Firefox 0.9.3.
(Reporter)

Updated

15 years ago
Attachment #155759 - Flags: first-review?(mostafah)
(Reporter)

Updated

15 years ago
(Assignee)

Comment 2

15 years ago
Checked in.
Thanks
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
(Assignee)

Updated

15 years ago
Attachment #155759 - Flags: first-review?(mostafah) → first-review+
The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!
QA Contact: gurganbl → sunbird
You need to log in before you can comment on or make changes to this bug.