255187 - Focus lost after closing bookmarks or history w/ kbd

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Aaron Leventhal]

Hit Ctrl+B or Ctrl+H twice to toggle sidebar open and then closed.
Focus lost, cannot scroll with keyboard.

Comment 1

[Aaron Leventhal]

This is a typical front-end accessibility bug. We're going to have a lot of
these as we start to look at Firefox accessibility issues.

Comment 2

[Mike Connor [:mconnor]]

Steffen, this is probably yours.

Aaron: so we should basically do _content.focus() on closing the sidebar?

Comment 3

[Steffen Wilberg]

Attachment: patch

No, I didn't touch this in bug 188910. But this works fine.

Comment 4

[Aaron Leventhal]

Comment on attachment 155821 [details] [diff] [review]
patch

This works fine, but can you look at making a more general fix? For example, if
focus is on something that gets hidden, destroyed or disabled, focus should
automatically move to the next focusable item. If that's too much work or
beyond what you're willing to get into, we should file a bug to do that and
check in this temporary fix. We can remove the code when the more general fix
goes in later.

This isn't yours, but I noticed an extra semicolon:  
elt.setAttribute("checked", "true");;

Comment 5

[Aaron Leventhal]

*** Bug 254056 has been marked as a duplicate of this bug. ***

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 155821 [details] [diff] [review]
patch

yeah, it'd be better to have a global fix, but lets spin off a separate bug for
that, since its probably a more comprehensive fix and this isn't a good time
for that type of fix.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 155821 [details] [diff] [review]
patch

a=asa for aviary checkin.

Comment 8

[Steffen Wilberg]

Checked into br & trunk 08/12/2004 02:09-02:17.

I have no idea about fixing the general problem.

Comment 9

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change

Comment 10

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381