Closed Bug 255576 Opened 17 years ago Closed 17 years ago
Add Live Bookmarks to glossary
This should be a simple task. Just add an entry into glossary.xhtml, add a corresponding entry to firebird-glossary.rdf and to firebird-index1.rdf, and you're done. I probably won't get to this, but this feature's new for 1.0, and we should at least mention cool new features. Please, if you have ten minutes, make a patch for it.
Okay, maybe I have gotten to it. :-) The patch is simple. First, add two entries to the glossary RDF backend: one for "live bookmark", one for "feed" (I feel only adding "live bookmark" would result in either a huge entry or an incomprehensible entry for a feeds newbie). Second, add entries to glossary.xhtml for "live bookmark" and "feed". Third, add "live bookmark" to the index RDF backend (I didn't add "feed" because it exists only to support the "live bookmark" definition). The definitions I've written are probably not the greatest, but they should work for Firefox 1.0. We need at least /something/ for before then, and this does the trick.
Comment on attachment 156082 [details] [diff] [review] Add live bookmark to glossary Requesting review from rlk, hoping this is good enough for 1.0 so that live bookmarks are at least mentioned...
Attachment #156082 - Flags: review?(rlk)
Comment on attachment 156082 [details] [diff] [review] Add live bookmark to glossary firstname.lastname@example.org
Attachment #156082 - Flags: review?(rlk) → review+
Jeff, you're using the wrong TOC. That TOC isn't being built. It shouldn't be there. The right one is in mozilla/toolkit/components/help/helpOnHelp. Your patch doesn't apply too, btw. Not sure why. You might be using an older revision. Is it possible for your to redo your changes on the right TOC?
And please run cvs diff from above mozilla/, so that I can run the patch command from there as well.
Testing patches should get noticeably easier in something over a week, when I'm getting a new laptop that's seven times faster than the old PII computer I use now and has triple the RAM (not to mention the ample hard drive space for complete builds). As it is now I'd never notice problems like the glossary issue, because at four hours to build it's simply not practical. Can we remove that file (probably help-toc.rdf too) for neatness? I'm fine with doing diffs from the top of the hierarchy, but as no one had ever mentioned a problem I wasn't about to slightly complicate things for myself by requiring the typing of long pathnames at the commandline.
Attachment #156082 - Attachment is obsolete: true
Attachment #156105 - Flags: review?(rlk)
Comment on attachment 156105 [details] [diff] [review] Better? Thanks Jeff!
Attachment #156105 - Flags: review?(rlk) → review+
Better! Checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.0beta
You need to log in before you can comment on or make changes to this bug.