255803 - update website needs to handle version numbers correctly

Status: RESOLVED DUPLICATE of bug 304857

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

The version strings stored in varchar(10)s in Version, MinAppVer, MaxAppVer are
treated as decimals by various functions in update.mozilla.org code. 

Instead, they should be treated as Firefox Version Format strings, which
requires some special parsing and analysis. See 

http://lxr.mozilla.org/aviarybranch/source/toolkit/mozapps/extensions/service/Version.java

Comment 1

[chris hofmann]

any progress on this one?  how critical is this for holding up the initial PR push?

Comment 2

[Wolf [:wolf]]

(In reply to comment #1)

I wouldn't hold PR for this, as its pretty much stalled. The "functions" in
Update code that don't parse the string properly are part the MySQL query
strings. MySQL itself doesn't seem to have string functions suitable to resolve
this bug. That I've found in the MySQL 4.x manual. I haven't found another way
to do this either. (having PHP parse it, as Ben has had Java do in the link
provided, would require returning the whole list each time, I'm pretty sure.
which is unacceptable, IMO).

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

OK. 

Comment 4

[Wolf [:wolf]]

*** Bug 263994 has been marked as a duplicate of this bug. ***

Comment 5

[Wolf [:wolf]]

*** Bug 264970 has been marked as a duplicate of this bug. ***

Comment 6

[alanjstr]

There are several bugs that relate to the sorting of versions being incorrect. 
I suggest that we correct this by having columns for major, minor, subver, and
build, like we do for t_applications.  This would be more correct than Date
Updated because someone can add/edit an older version.

This will not only require a db change, but some php to change when inserting
the record and querying.

RSS and XML export are dependent.

Comment 7

[Wolf [:wolf]]

Date Updated isn't what's used.

Comment 8

[Wolf [:wolf]]

Bulk Moving Developer Control Panel bugs to new component.
(Filter: massdevcpspam)

Comment 9

[Benjamin Smedberg]

*** This bug has been marked as a duplicate of 304857 ***