Closed Bug 255895 Opened 16 years ago Closed 15 years ago
.2 must die (was: Page with menus looks good in milestones and older releases; fails with recent nightlies)
1.04 KB, text/html
1.59 KB, patch
|Details | Diff | Splinter Review|
9.74 KB, text/plain
13.57 KB, image/png
User-Agent: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3 Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3 Please compare http://www.fuchsmizrachi.org in Firefox 0.9.3 vs. recent FF branch nightlies such as Aug 11 and Aug 16. The page looks good in the milestone (and older versions of FF). With the recent nightlies, the menus in the upper left do not appear. See also this thread in the Firefox Bugs forum: http://forums.mozillazine.org/viewtopic.php?t=114796&highlight= Reproducible: Always Steps to Reproduce: 1. Visit http://www.fuchsmizrachi.org with milestone 0.9.3. 2. Visit same with recent branch nightly. Actual Results: Page looks very good with milestone. Menus are missing with nightly. See discussion in Firefox Bugs forum: http://forums.mozillazine.org/viewtopic.php?t=114796&highlight=
I'll summarize what I said in that forum topic. This seems like a regression of fixing bug 248549, regressed in trunk builds from 2004/07/23 and later. The menu script uses: ie=(document.all != (void 0)); which evaluates to true from 2004/07/23 and later on. Before that it evaluated to false. (void 0) is equal to undefined. See also bug 248549, comment 49. The assumption made in that comment, seems at least in this case to be wrong (however, in general this is probably true).
Component: Browser-General → DOM: Level 0
OS: Windows ME → All
This is the link to the script that generates the menu and which uses 'ie=(document.all != (void 0));': http://www.fuchsmizrachi.org/popouttext.js
I suspect that this is a byproduct of bug 248549, which exposes document.all unless it is detected first. My hypothesis is that the syntax: ie = (document.all != (void 0)); is taken to be a *use* of document.all, which makes newer builds expose it, and therefore the expression evaluates to true.
interesting if unconventional detection code. I have contacted the site and hope to hear back soon. I think we can treat this as evangelism unless Brendan wishes to support the comparison against (void 0).
I'd like not to cope with (void 0), because I bet after bloating jsobj.c:Detecting with code to match the JS bytecode generated for that special form, there'll be a variation that requires smarter matching, or just more brute-force matching. If this comes up again, though, please confirm and dup. /be
Status: UNCONFIRMED → NEW
Component: DOM: Level 0 → English Other
Ever confirmed: true
Product: Browser → Tech Evangelism
Version: Trunk → unspecified
Assignee: general → nobody
QA Contact: general → nobody
Hardware: PC → All
Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7.2) Gecko/20040827 Firefox/0.9.1+ I presume this release contains changes made for bug #256932 ? Menus now appear when page is loaded--but hovering over them produces garbage instead of submenus.
Neil, yes I believe the recent 0.9.x nightly builds of FF do contain the undetected document.all. I have written to the site explaining the situation and asking them to change ie = (document.all != (void 0)) to ie = (document.all != null), however I have not heard back from them. Perhaps if you could contact them it would help. This use of (void 0) in a detection scheme is rather unique. The addition of the undetected document.all provides significant improvement on older sites and sites which are coded solely for MSIE and which do not use significant MSIE features. It is unfortunate that these changes have broken this particular site, but I still believe that the benefit outweighs the cost.
Component: English Other → General
Product: Tech Evangelism → Firefox
minus for PR, watch for additional feedback...
Flags: blocking-aviary1.0PR? → blocking-aviary1.0PR-
This is the place where these pop-out menus gets sold: http://www.thetemplatestore.com/popoutmenu/ It might be a good idea to contact the author of that menu, that Mozilla's behavior has changed regarding document.all. (Thanks to danm, http://forums.mozillazine.org/viewtopic.php?t=127993&sid=ea8f063553798a80263cb24104570c44 )
so far, document.all changes seem to be holding up ok. -minusing this bug, and hoping we can evangelize the few sites where we have problems.
Flags: blocking-aviary1.0? → blocking-aviary1.0-
brendan, jst, ideas?
Assignee: nobody → brendan
Product: Firefox → Browser
Target Milestone: --- → mozilla1.8alpha5
Version: unspecified → 1.0 Branch
Status: NEW → ASSIGNED
Priority: -- → P1
Summary: Page with menus looks good in milestones and older releases; fails with recent nightlies → JS1.2 ==/!== must die (was: Page with menus looks good in milestones and older releases; fails with recent nightlies)
*** Bug 263578 has been marked as a duplicate of this bug. ***
updated menu available at <http://www.ecommercetemplates.com/free_downloads.asp>. I contacted the site about updating.
Summary: JS1.2 ==/!== must die (was: Page with menus looks good in milestones and older releases; fails with recent nightlies) → JS1.2 ==/!= must die (was: Page with menus looks good in milestones and older releases; fails with recent nightlies)
time is growing short for RC1
in talking with bob and brendan on this I going to minus for 1.0. we should get a change for this on the trunk and let it go throught a 1.8 alpha and beta. probably not a lot of risk in making this change, but it would to have it go though a good testing cycle...
Flags: blocking-aviary1.0+ → blocking-aviary1.0-
Summary: JS1.2 ==/!= must die (was: Page with menus looks good in milestones and older releases; fails with recent nightlies) → JS1.2 must die (was: Page with menus looks good in milestones and older releases; fails with recent nightlies)
Bob, feel free to test the heck out of this patch. Thanks, /be
Target Milestone: mozilla1.8alpha5 → mozilla1.8beta2
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
(In reply to comment #6) > Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7.2) Gecko/20040827 Firefox/0.9.1+ > > I presume this release contains changes made for bug #256932 ? > > Menus now appear when page is loaded--but hovering over them produces garbage > instead of submenus. Not fixed in Deer Park Alpha 1 Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.8b2) Gecko/20050531 Firefox/1.0+
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
for historical purposes
You need to log in before you can comment on or make changes to this bug.