25592 - [RFE] Addition of "Promote frame to full" to context menu

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, enhancement, P1)

Description

[Aaron Andersen]

The first item on the right click menu when the current page includes frames is 
"Open frame in new window".  I propose the additioin of a second menu item under 
it such as "Promote frame to full", which would open the currently selected 
frame in the full window.  This is the equivlent of clicking "open frame in new 
window" and then closing the first window.

This would be usefull for pages like mynetscape that open an ofsite link in a 
frame and, unlike mynetscape, do not provide a way to get rid of the frame.  An 
example of such a page occurs when clicking on link within an email using 
hotmail.

This enhancement could be done entirely in XUL, and in about 15 seconds.

Comment 1

[Mike Pinkerton (not reading bugmail)]

content of menus not my department.

Comment 2

[Matthew T (active 1999-2002)]

I think this is 4.xP, but only for Unix, not for Windows or MacOS.

Perhaps a better wording would be `Open frame in whole window'. Or, `Hide other 
frame(s)' -- although the latter suggestion might give the mistaken impression 
that you could `Show [the] other frames' again later.

Comment 3

[don]

Cool idea.  Not hard to implement either.  Maybe we might actually do a geeky
thing like this ...

Comment 4

[don]

BTW ... Bill, what do you think of this idea?

Comment 5

[Bill Law]

Sounds good to me.  I'd use this feature.  I'm not sure I like "Promote frame to 
full" much.  "Hide other frames" suffers the problem already noted (how do I 
unhide them?).

I like "Zoom frame to fill window" (maybe even just "Zoom Frame."  "Zoom" is 
vague enough to not suffer the connotations of "hide" and is king of catchy, 
IMHO.

Anyway, here is the implementation.  We could tweak the .dtd entry to whatever 
we decide on...

Index: content/navigator.xul
===================================================================
RCS file: /cvsroot/mozilla/xpfe/browser/resources/content/navigator.xul,v
retrieving revision 1.132
diff -w -r1.132 navigator.xul
114a115,118
>         <menuitem id="context-zoomframe"
>                   value="&zoomFrameCmd.label;"
>                   accesskey=""
>                   oncommand="contextMenu.zoomFrame();"/>
Index: content/nsContextMenu.js
===================================================================
RCS file: /cvsroot/mozilla/xpfe/browser/resources/content/nsContextMenu.js,v
retrieving revision 1.9
diff -r1.9 nsContextMenu.js
78a79,81
>         // Remove zoom frame if not applicable.
>         this.showItem( "context-zoomframe", this.inFrame );
>
251a255,258
>     },
>     // Go to url of clicked-in frame.
>     zoomFrame : function () {
>         window.content.location.href = 
this.target.ownerDocument.location.href;
Index: locale/en-US/navigator.dtd
===================================================================
RCS file: /cvsroot/mozilla/xpfe/browser/resources/locale/en-US/navigator.dtd,v
retrieving revision 1.48
diff -w -r1.48 navigator.dtd
300a301,302
> <!ENTITY zoomFrameCmd.label           "Zoom Frame to Fill Window">
> <!ENTITY zoomFrameCmd.accesskey       "z">

Comment 6

[Matthew T (active 1999-2002)]

Erm, using `Zoom' would cause confusion with any future `Zoom in'/`Zoom out' 
feature (for magnifying Web pages or images, as Opera does).

Comment 7

[Richard Zach]

What's wrong with the NS 4.7 wording: "Open frame in window"?

Comment 8

[Matthew T (active 1999-2002)]

What's wrong with `Open frame in window' is that it makes it ambiguous whether 
the frame will open in the current window, or in a new window. And there would 
also be a minor feeling of `well, duh, the frame is *already* open in a window'.

Which is why I suggest `Open frame in whole window'.

Comment 9

[Richard Zach]

Hm, I think it's pretty clear when it's right next to "Open frame in new
window".  How about "Open frame in this window"?

Comment 10

[don]

Move to M16 for now ...

Comment 11

[Aaron Andersen]

Just as long as it doesn't get moved to M17 and then to M18 and then to M19 etc. 
all the way to M45...

Comment 12

[Chris Siebenmann]

 I wrote a patch for this (almost identical to [e-mail]'s) and was
all set to submit it when I found this bug/RFE.

 Can we please get this feature added, no matter what the actual menu
entry is called? The menu entry text is only in the DTD anyways, so it's
trivial to change it whenever a real decision is made. And in the mean
time it's a shame to hold up this Netscape 4.x feature while the exact
wording of a menu gets argued over.

 For what it's worth, I vote for 'Open Frame in Window', since that's
what Netscape 4.xx calls it.

 (And someone on #mozilla in irc said that net+/opera calls it 'Show Only
This Frame', which also strikes me as a good and clear menu label for it.)

Comment 13

[sairuh (rarely reading bugmail)]

*spam*: transferring current XP Menu bugs over to jrgm, the new component owner.
feel free to add me to the cc list (unless am the Reporter) of any of these, if
you have any questions/etc.

Comment 14

[Matthew T (active 1999-2002)]

Nominating for nsbeta3. This is a very small change, low risk, and would improve 
browsing substantially for advanced users.

Comment 15

[verah (gone)]

Nav triage team: [nsbeta3-]

Comment 16

[Matthew T (active 1999-2002)]

*** Bug 50450 has been marked as a duplicate of this bug. ***

Comment 17

[sairuh (rarely reading bugmail)]

either "Open Frame in This Window" or "Open Frame in Whole Window" would be fine
by me. transferring folx from bug 50450 over to here, reassigning to blake to
reflect this.

Comment 18

[Ben Bucksch (:BenB)]

blake, in the patch, make sure not to open the frame in the parent document, but
the top-level one (you might be stuck in several nested frames).
sairuh, tnx for moving us over.

Comment 19

[Blake Ross]

It will open it in window._content.location.href, which afaik should be 
the 'top-level' (e.g. main window) 

Comment 20

[Blake Ross]

Attachment: patch

Comment 21

[Blake Ross]

attached a new patch.  Bill really did the work here (back in March), so thanks 
much to him.  Bill, could you review this, please?

Comment 22

[Bill Law]

Code looks good.

I'm not thrilled with the phrase "Open Frame in Whole Window."  It just makes me
want to go "Huh?".

"Open Frame in This Window" seems less confusing.  Makes for a nice set along
with "Open Frame in New Window."  The end result is essentially the same, one in
a new window, one in this (the current) window.

Comment 23

[Ben Bucksch (:BenB)]

I agree with law.

Comment 24

[Blake Ross]

I also am not a big fan of the wording.  I changed it as a result of Matthew's 
3/17 comment:

"What's wrong with `Open frame in window' is that it makes it ambiguous whether 
the frame will open in the current window, or in a new window. And there would 
also be a minor feeling of `well, duh, the frame is *already* open in a window'.

Which is why I suggest `Open frame in whole window'."

Open Frame in This Window could still be a little ambiguous (if the user 
doesn't understand that the window is...well...a window, and not a frame), but 
I like it better than saying "whole window"...

Comment 25

[Bill Law]

The ambiguity of "whole" is comparable to that of "Open frame in window," IMHO.

Which window will be whole? this one, or the new one?  Isn't this window already
"whole?"

"Hide other frames"?
"Expand frame in this window"?
"This frame only"?
"Click here and see what happens"?

Oh, I know.  Let's make it a pref!

Please note that I don't mean to hold up progress (and getting the option in,
with *any* wording is progress).  I just don't care much for "Open Frame in
Whole Window."

Since you're doing the code, Blake, I say you check it in the way you want it
and make the rest of us suffer.  They do permit us some artistic license, I suppose.

Comment 26

[Matthew T (active 1999-2002)]

Props to whoever it was on #mozilla who suggested `Show Only This Frame'. That 
sounds like the best suggestion so far.

Comment 27

[Aaron Andersen]

I agree.  "Show Only This Frame" is the best thing I've heard so far.  Even if 
it does slightly imply that the other frames are still loaded, just hidden.  But 
I would be satisfied with a blank label if we could just get this fixed.

Comment 28

[Blake Ross]

OK.  I'll change it to "Show Only This Frame" for now (or would "Show This 
Frame Only" be better?), and someone can file a separate bug to change the 
wording if they don't like it.  And if you're really that opposed to it, as 
Bill says, you can suffer :-)

Bill, once I change the wording, is that an r=law?

Comment 29

[Bill Law]

r=law

This is a feature I'll definitely use myself, too.

Comment 30

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Good work nailing this down, and good patch.

sr=shaver

Comment 31

[Blake Ross]

Fix checked in to trunk! (QA -> sairuh since xpapps, cc jrgm b/c i don't know 
if he cares about this bug or not)

Comment 32

[John Morrison]

Hey, I care. I think this is a very cool feature, and especially since our 
new window time is a bit lacking, I'll definitely be using this when I 
want to "de-frame" a site. 

Comment 33

[Jacob Steenhagen]

Works great for me w/2000101704 on Win2K

Comment 34

[Jacob Steenhagen]

Also, I filed bug 55960 to request an expansion of this feature... the ability
to get the frames back (Hide [or what I called collapse] vs Destroy).

Comment 35

[sairuh (rarely reading bugmail)]

cool! now says, Show Only This Frame. works just spiffily. vrfy fixed with
2000.11.21.08 [linux/winnt] and 2000.11.21.13 [mac].

Comment 36

[Blake Ross]

One day I'd like to look into just destroying all other frames and then 
resizing the frame to the viewport (so it just has to reflow, not navigate to 
the frame again) which presumably would make this much faster...

Comment 37

[Ben Bucksch (:BenB)]

Just to make sure, I understand this: After the command, the other frames are
gone. They they don't take up any resources anymore. You are just speaking about
performance for executing the command itself. Right?

Comment 38

[timeless]

Due to history arch rules we aren't actually allowed to free those resources 
entirely because we're expected to regenerate the page when the user navigate 
backwards. *shrug*

Comment 39

[Blake Ross]

Yes.  I'm just saying that it's silly to reload/re-navigate to the page when 
we've already retrieved a copy of it.

Comment 40

[Matthew T (active 1999-2002)]

And of course reloading the frame runs the risk of the new version being 
completely different from the old version, like with all the bugs blocked by 
bug 56346.

Comment 41

[Oleg Khokhlov]

This menu item ("Show Only This Frame") is absent in Netscape6 OEM bugfix 
release on Solaris.

Platform&OS: Solaris 2.7 Sparc and Intel.
Build: NS6 bugfix OEM release.

Comment 42

[Ben Bucksch (:BenB)]

This bug is trunk only, i.e. not in Netscape 6.0. Closing again.

Comment 43

[sairuh (rarely reading bugmail)]

...and re-vrfy...