256292 - Incorrect charset in dictionary aff file causes a crash [@ myspAffixMgr::get_try_string ]

Status: RESOLVED WORKSFORME

(Core :: Spelling checker, defect)

Description

[Robert Strong (they/them - no direct email)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040819 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040819 Firefox/0.9.1+

Selecting the Bulgarian dictionary that is hosted on
http://dictionaries.mozdev.org/ in either the Mozilla Suite or Thunderbird
causes the application to crash. I have sent an email to dictionaries at mozdev
dot org to let the maintainer know about this issue.

Reproducible: Always
Steps to Reproduce:
1. Install the Bulgarian dictionary from
http://downloads.mozdev.org/dictionaries/spell-bg.xpi
2. Start a spell check
3. Select the Bulgarian dictionary

Actual Results:  
The application crashed

Expected Results:  
The application should not crash even if the dictionary cannot be used (e.g.
formatted incorrectly, etc.).

Faulting application mozilla.exe, version 1.7.20040.61609, faulting module
myspell.dll, version 1.7.20040.61609, fault address 0x0000256d.

Comment 1

[Robert Strong (they/them - no direct email)]

I verified that this also occurs with:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a3) Gecko/20040817

Comment 2

[Robert Strong (they/them - no direct email)]

I did a little investigating and found that the first line of the aff file read
as SET microsoft-cp1251

Changing it to SET cp1251 appears to fix the dictionary. I will see what I can
do about getting the dictionary fixed on mozdev... hope this info helps.

Comment 3

[alanjstr]

Mozilla.org is not responsible for extensions hosted on mozdev.org.  You should
contact the project mailing list, [e-mail]

Comment 4

[Robert Strong (they/them - no direct email)]

(In reply to comment #3)
> Mozilla.org is not responsible for extensions hosted on mozdev.org.  You should
> contact the project mailing list, [e-mail]
I never stated you were responsible for [e-mail]... I did ask for
your help in the hopes that you would know who to contact and did state that I
have tried to contact the maintainer using the email of [e-mail].

Also, this bug should not have been marked resolved since setting the charset to
an incorrect value should not crash the application as you would have noticed if
you had read the bug report. It seems as if you think the bug has to do with you
fixing the dictionaries at mozdev... which it does not.

Having said that, I will leave it up to someone else that knows how to resolve
the dictionary issue... please keep in mind that the "Download More: for the
spell checkers in both the Suite and Thunderbird point to the
dictionaries.mozdev.org site so the products themselves point to a location
where the dictionary that causes the crash is located.

Comment 5

[Robert Strong (they/them - no direct email)]

Updating subject to be descriptive of the bug

Comment 6

[alanjstr]

Try looking at the member list at http://dictionaries.mozdev.org/members.html in
case the mailing list is thinking you're spam.

Now it sounds like a mozilla problem.  Since I don't use Moz or TB, I can't
confirm, though.

Comment 7

[Robert Strong (they/them - no direct email)]

I sent an email directly to the maintainer and specifically asked for a reply so
as to know whether to try to get that aspect of this issue resolved through a
different method. I also sent one to feedback at mozdev since it appears that
the maintainer is MIA.

I also sent an email to the person who brought this issue to my attention and
asked them to confirm this bug.

Comment 8

[Robert Strong (they/them - no direct email)]

The maintainer replied to the email sent to his member's address. I gave him the
info on how to fix this as well as a link to a repackaged version. Since the
original test may not work in the near future I copied the original dictionary
xpi to my server - http://exchangecode.com/bg/spell-bg.xpi - and I also changed
the bug URL to this dictionary so the maintainer of dictionaries.mozdev.org can
fix the dictionary that brought this issue to light.

Comment 9

[velinkk]

(In reply to comment #8)
> The maintainer replied to the email sent to his member's address. I gave him the
> info on how to fix this as well as a link to a repackaged version. Since the
> original test may not work in the near future I copied the original dictionary
> xpi to my server - http://exchangecode.com/bg/spell-bg.xpi - and I also changed
> the bug URL to this dictionary so the maintainer of dictionaries.mozdev.org can
> fix the dictionary that brought this issue to light.

I amso expirienced the same problem. It causes the browser to quit without any messages every single 
time it tries to load the dictionary.

Comment 10

[Robert Strong (they/them - no direct email)]

Attachment: testcase

Attaching a minimal Bulgarian dictionary xpi - original aff file and only one
word in the dictionary

Comment 11

[Robert Strong (they/them - no direct email)]

Adding keyword testcase.

The testcase will install a minimal Bulgarian dictionary with one word in the
dic file that will cause a crash when it is selected in the spell checker. Since
it causes a crash the preference for the dictionary is not save so it will not
prevent spell checking upon restart.

I also sent talkback incident id TB673990Y for this issue.

Comment 12

[Robert Strong (they/them - no direct email)]

Attachment: TalkBack Incident ID TB673990Y

Comment 13

[Robert Strong (they/them - no direct email)]

The Bulgarian dictionary has been updated on dictionaries.mozdev.org by the
maintainer of same.

Comment 14

[timeless]

Comment on attachment 157266 [details]
TalkBack Incident ID TB673990Y

this attachment is useless, please don't attach this kind again. the talkback
data is only useful when it reaches the server and is available from
talkback-public

Comment 15

[Robert Strong (they/them - no direct email)]

Talkback from the testcase
TB15556150Z

Comment 17

[Wayne Mery (:wsmwk)]

does testcase still produce crash?

bug 385742 is currently the only other confirmed spell crash

Comment 18

[Robert Strong (they/them - no direct email)]

(In reply to comment #17)
> does testcase still produce crash?
> 
> bug 385742 is currently the only other confirmed spell crash
Unzip the xpi, place the bg.aff and bg.dic in your dictionaries directory, open a page with a textarea, and try to spellcheck text in the textarea. Crash still happens.
Report ID: 32e91638-5101-49e0-8912-cb58a2090118

Comment 19

[Wayne Mery (:wsmwk)]

grr, can't pull up bp-32e91638-5101-49e0-8912-cb58a2090118

Comment 20

[Wayne Mery (:wsmwk)]

Marcoa, can you reproduce?

Comment 21

[Marco A.G.Pinto [:marcoagpinto]]

@Wayne Mery:
No wonder it crashed, because in the .AFF which I downloaded from Bugzilla above it has:
SET microsoft-cp1251

In TB 38.7.1 it doesn't allow to install the .xpi saying it is damaged.

However, I tried to install the one from:
https://addons.mozilla.org/en-GB/thunderbird/addon/bulgarian-dictionary/?src=userprofile
and it has:
SET windows-1251
in the .AFF and I had no issues with it.

Comment 22

[Marco A.G.Pinto [:marcoagpinto]]

Attachment: Screeshot of TB 38 with Hungarian speller

Comment 23

[Marco A.G.Pinto [:marcoagpinto]]

@Wayne Mery:
It doesn't crash TB 38.

I had the pt_PT speller that came with TB and the Hungarian one which I downloaded from the add-ons page.

I then replaced the new .AFF + .DIC in their folder with the testcase and when I opened TB and created a new message, I type garbage just to test and when I select the Hungarian speller using the top left combobox a window opens with suggestions.

But no crashes.

Does this solve the issue?