256328 - Page is layed out with horizontal rules through most of page background

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Joe McCabe]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a3) Gecko/20040819
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a3) Gecko/20040819

The Bob Cringely column uses a lot of CSS. It seems to break when viewed in Mozilla.



Reproducible: Always
Steps to Reproduce:

Comment 1

[Joe McCabe]

Attachment: Screen capture of Mozilla displaying page

Comment 2

[Joe McCabe]

Attachment: Screen capture of Konqueror displaying page

Comment 3

[Bill Mason]

WFM 20040817 PC/Win2000

Comment 4

[Boris Zbarsky [:bzbarsky]]

Minimal testcase needed.

Comment 5

[Joe McCabe]

Attachment: A reduced test case.

This tarball contains an HTML file, a CSS file, and the background image that
the CSS file refers to.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: The image

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase using that image

Comment 8

[Boris Zbarsky [:bzbarsky]]

Not an issue on Windows, but I do see this on Linux.  The image has white on the
left and transparent on the right, and the transparent part paints the line garbage.

tor, could you check this out, please?  This looks similar to bug 245377...

Comment 9

[tor]

FWIW, I see this on a fedora core 1 machine (s3 savage) but not on a fedora
core 2 box (i845).  X server bug with tile/stipple with rop, maybe?

Comment 10

[Boris Zbarsky [:bzbarsky]]

Possible, but may be worth working around if so...

Comment 11

[Joe McCabe]

I see this on a Red Hat 9 box, but it's had many packages updated over a long
period. It is far from vanilla.

Comment 12

[tor]

This change after XFree86 4.3 looks somewhat suspicious:

 660. Fix a bug in the fbgc.c code that caused the even stipple code path to
      be used instead of the odd stipple path. Basically causing glitches in
      rendering or no rendering at all. (Alan Hourihane).

Comment 13

[tor]

Attachment: use old tiling method for buggy X servers

Built a couple servers with and without the fbgc fixes, and that did
appear to be the problem.  This patch restores the old tiling code
that was deleted in bug 244506 and uses it on XFree86 <= 4.3.

Comment 14

[Christopher Blizzard (:blizzard)]

Comment on attachment 158996 [details] [diff] [review]
use old tiling method for buggy X servers

Nice catch.

Comment 15

[Asa Dotzler [:asa]]

Comment on attachment 158996 [details] [diff] [review]
use old tiling method for buggy X servers

a=asa for checkin to 1.8a4

Comment 16

[tor]

Checked in on trunk.

Comment 17

[Elmar Ludwig]

The patch does not completely fix the problem here: The commit mentioned in
comment #12 was added to the XFree CVS on 2003-12-09, well after the release
of XFree86 4.3.0.1 on 2003-03-09. Later 4.3.0.x releases might be affected as
well since the commit message on XFree's cvs-commit list indicates that this
was fixed on the trunk only, see:

http://www.mail-archive.com/[e-mail]/msg02882.html

This means that current Mozilla builds will use the broken code path at least
on XFree86 4.3.0.1 (and probably all 4.3.0.x releases). I can confirm the bad
rendering with XFree 4.3.0.1 and a Firefox 1.5 branch build about a week old,
so I'm reopening this bug now.

> +  if (strstr(ServerVendor(dpy), "XFree86") && VendorRelease(dpy) <= 40300000)
> +    sNeedSlowTile = PR_TRUE;

To be on the safe side, I guess it would be better to check:

  if (strstr(ServerVendor(dpy), "XFree86") && VendorRelease(dpy) < 40400000)

Comment 18

[Elmar Ludwig]

*** Bug 295127 has been marked as a duplicate of this bug. ***

Comment 19

[Elmar Ludwig]

*** Bug 307782 has been marked as a duplicate of this bug. ***

Comment 20

[Elmar Ludwig]

Attachment: use old tiling method also for 4.3.0.x

proposed patch

Comment 21

[Boris Zbarsky [:bzbarsky]]

Elmar, you want to request review on patches if you expect them to get noticed... :(

Comment 22

[Elmar Ludwig]

Yeah, I should have seen that I had forgotten something. Thanks for noticing this.

Comment 23

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 195849 [details] [diff] [review]
use old tiling method also for 4.3.0.x

conservative fix, probably worth having on branch

Comment 24

[Boris Zbarsky [:bzbarsky]]

Checked that patch in on the trunk.  Elmar Ludwig, thanks for the patch!

Comment 25

[Boris Zbarsky [:bzbarsky]]

Fixed on 1.8 branch.