Closed Bug 256363 Opened 21 years ago Closed 21 years ago

Change Help docs on Download Manager shortcut

Categories

(Firefox Graveyard :: Help Documentation, defect)

Product:
Firefox Graveyard
Component:
Help Documentation
Version:
1.0 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox1.0beta

People

(Reporter: jwalden+fxhelp, Assigned: jwalden+fxhelp)

References

Details

(Keywords: fixed-aviary1.0)

Attachments

(1 file, 1 obsolete file)

Patch for Ctrl-J
2.64 KB, patch
steffen.wilberg
: review+
Details | Diff | Splinter Review
to what? I can do this real quick if you want.
Attached patch Patch (obsolete) — — Splinter Review
Attachment #156649 - Flags: review+
Fix checked in on aviary branch and trunk.
Status: NEW → RESOLVED
Closed: 21 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Yippee. Ctrl+Shift+[0-9a-z] conflicts with an ISO standard (bug 186789 and bug 250396 comment 7). It's looking like Ctrl+J is it (and Page Info shortcut in Windows goes away), but if I understand it right, bonsai seems to say the DTD file for the download manager key wasn't changed in the latest checkin to "fix" it. I'm waiting a day or so on this until the dust settles and the devs have a clue here. ;-)
Status: RESOLVED → REOPENED
Keywords: fixed-aviary1.0
Resolution: FIXED → ---
Flags: blocking-aviary1.0PR+
Under Tools, it now says "Downloads Ctrl+E" although both Ctrl+E and Ctrl+J do nothing.
Hussam, this bug is about correcting the Help documentation of the shortcut. Bug 250396 is about changing the shortcut. Ctrl+E focusses the Search bar right now. I just noted that in bug 250396.
Depends on: 250396
Summary: Change Download Manager shortcut → Change Help docs on Download Manager shortcut
anyone have thoughts on a fix. not much time left until the PR release
(In reply to comment #7) > anyone have thoughts on a fix. not much time left until the PR release Until bug 250396 is done, we can't really produce a valid fix. Thats why it's marked as a dependency.
Attached patch Patch for Ctrl-J — — Splinter Review
(In reply to comment #7) > anyone have thoughts on a fix. not much time left until the PR release Now that the full fix is checked into Bonsai, this is fixable (although there still might be some issues remaining in bug 250396 - will keep an eye on bonsai/mail for any latent issues).
Attachment #156649 - Attachment is obsolete: true
Attachment #156947 - Flags: review?(rlk)
Attachment #156947 - Flags: review?(rlk) → review+
Checked in br & trunk. I'm removing the dependency on bug 250396 since that won't change Ctrl+J again.
Status: REOPENED → RESOLVED
Closed: 21 years ago → 21 years ago
No longer depends on: 250396
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.0beta
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: