Change Help docs on Download Manager shortcut

VERIFIED FIXED in Firefox1.0beta

Status

Firefox Graveyard
Help Documentation
VERIFIED FIXED
14 years ago
2 years ago

People

(Reporter: Jeff Walden (gone starting June 8), Assigned: Jeff Walden (gone starting June 8))

Tracking

({fixed-aviary1.0})

1.0 Branch
Firefox1.0beta
fixed-aviary1.0
Bug Flags:
blocking-aviary1.0PR +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

14 years ago
 

Comment 1

14 years ago
to what? I can do this real quick if you want.

Updated

14 years ago
Attachment #156649 - Flags: review+

Comment 3

14 years ago
Fix checked in on aviary branch and trunk.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
(Assignee)

Comment 4

14 years ago
Yippee.  Ctrl+Shift+[0-9a-z] conflicts with an ISO standard (bug 186789 and bug
250396 comment 7).  It's looking like Ctrl+J is it (and Page Info shortcut in
Windows goes away), but if I understand it right, bonsai seems to say the DTD
file for the download manager key wasn't changed in the latest checkin to "fix"
it.  I'm waiting a day or so on this until the dust settles and the devs have a
clue here.  ;-)
Status: RESOLVED → REOPENED
Keywords: fixed-aviary1.0
Resolution: FIXED → ---

Updated

14 years ago
Flags: blocking-aviary1.0PR+

Comment 5

14 years ago
Under Tools, it now says "Downloads Ctrl+E" although both Ctrl+E and Ctrl+J do
nothing.

Comment 6

14 years ago
Hussam, this bug is about correcting the Help documentation of the shortcut.
Bug 250396 is about changing the shortcut. Ctrl+E focusses the Search bar right
now. I just noted that in bug 250396.
Depends on: 250396
Summary: Change Download Manager shortcut → Change Help docs on Download Manager shortcut

Comment 7

14 years ago
anyone have thoughts on a fix.  not much time left until the PR release

Comment 8

14 years ago
(In reply to comment #7)
> anyone have thoughts on a fix.  not much time left until the PR release

Until bug 250396 is done, we can't really produce a valid fix. Thats why it's
marked as a dependency.
(Assignee)

Comment 9

14 years ago
Created attachment 156947 [details] [diff] [review]
Patch for Ctrl-J

(In reply to comment #7)
> anyone have thoughts on a fix.  not much time left until the PR release

Now that the full fix is checked into Bonsai, this is fixable (although there
still might be some issues remaining in bug 250396 - will keep an eye on
bonsai/mail for any latent issues).
(Assignee)

Updated

14 years ago
Attachment #156649 - Attachment is obsolete: true
(Assignee)

Updated

14 years ago
Attachment #156947 - Flags: review?(rlk)

Updated

14 years ago
Attachment #156947 - Flags: review?(rlk) → review+

Comment 10

14 years ago
Checked in br & trunk.
I'm removing the dependency on bug 250396 since that won't change Ctrl+J again.
Status: REOPENED → RESOLVED
Last Resolved: 14 years ago14 years ago
No longer depends on: 250396
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.0beta

Updated

14 years ago
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.