256363 - Change Help docs on Download Manager shortcut

Status: VERIFIED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Jeff Walden (gone starting June 8)]

Comment 1

[R.J. Keller]

to what? I can do this real quick if you want.

Comment 2

[Jeff Walden (gone starting June 8)]

Attachment: Patch

Comment 3

[R.J. Keller]

Fix checked in on aviary branch and trunk.

Comment 4

[Jeff Walden (gone starting June 8)]

Yippee.  Ctrl+Shift+[0-9a-z] conflicts with an ISO standard (bug 186789 and bug
250396 comment 7).  It's looking like Ctrl+J is it (and Page Info shortcut in
Windows goes away), but if I understand it right, bonsai seems to say the DTD
file for the download manager key wasn't changed in the latest checkin to "fix"
it.  I'm waiting a day or so on this until the dust settles and the devs have a
clue here.  ;-)

Comment 5

[Hussam Al-Tayeb]

Under Tools, it now says "Downloads Ctrl+E" although both Ctrl+E and Ctrl+J do
nothing.

Comment 6

[Steffen Wilberg]

Hussam, this bug is about correcting the Help documentation of the shortcut.
Bug 250396 is about changing the shortcut. Ctrl+E focusses the Search bar right
now. I just noted that in bug 250396.

Comment 7

[chris hofmann]

anyone have thoughts on a fix.  not much time left until the PR release

Comment 8

[R.J. Keller]

(In reply to comment #7)
> anyone have thoughts on a fix.  not much time left until the PR release

Until bug 250396 is done, we can't really produce a valid fix. Thats why it's
marked as a dependency.

Comment 9

[Jeff Walden (gone starting June 8)]

Attachment: Patch for Ctrl-J

(In reply to comment #7)
> anyone have thoughts on a fix.  not much time left until the PR release

Now that the full fix is checked into Bonsai, this is fixable (although there
still might be some issues remaining in bug 250396 - will keep an eye on
bonsai/mail for any latent issues).

Comment 10

[Steffen Wilberg]

Checked in br & trunk.
I'm removing the dependency on bug 250396 since that won't change Ctrl+J again.