257099 - GOK GUI can't grab Combobox

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Louie Zhao]

Combox can't be grabbed by GOK UI-Grab.

Comment 1

[Louie Zhao]

Attachment: patch v1

Comment 2

[Aaron Leventhal]

Comment on attachment 157132 [details] [diff] [review]
patch v1

>+    else {
>+      nsCOMPtr<nsIDOMElement> element(do_QueryInterface(mDOMNode));
>+      if (element) {
>+        rv = element->GetAttribute(NS_LITERAL_STRING("label"), label);

Use an nsIDOMXUL interface instead if one is available.

>+      nsCOMPtr<nsIDOMElement> element(do_QueryInterface(childNode));
>+      if (element) {

Use an assertion instead of |if (element)|

>+  if (boxName.Equals(NS_LITERAL_STRING("textbox")))
>+    // autocomplete textbox also uses nsXULComboboxAccessible and we need walk anonymous children
>+    CacheChildren(PR_TRUE);
>+  else
>+    // Argument of PR_FALSE indicates we don't walk anonymous children for menuitems
>+    CacheChildren(PR_FALSE);

I recommend using { and } to group these items so that no one gets confused.
Not a big deal, but Jst asked me to start using { and } for single line grouped
statements.

Comment 3

[Louie Zhao]

Attachment: patch v2

following Aaron's comments.

Comment 4

[Aaron Leventhal]

Louie, can you pinch Henry and get this sr='d and ready to go in? Thanks.

Comment 5

[Henry Jia]

Comment on attachment 157600 [details] [diff] [review]
patch v2

sr=Henry

Comment 6

[Louie Zhao]

Thanks for r & sr. patch checked in.