Apply fix in bug 217640 to Password manager for list sort exact match

RESOLVED FIXED

Status

()

Toolkit
Password Manager
RESOLVED FIXED
14 years ago
10 years ago

People

(Reporter: tracy, Assigned: Brian Ryner (not reading))

Tracking

({fixed-aviary1.0})

1.7 Branch
fixed-aviary1.0
Points:
---
Bug Flags:
blocking-aviary1.0 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

911 bytes, patch
Ben Goodger (use ben at mozilla dot org for email)
: review+
Ben Goodger (use ben at mozilla dot org for email)
: approval-aviary+
Details | Diff | Splinter Review
779 bytes, patch
jst
: review+
Details | Diff | Splinter Review
(Reporter)

Description

14 years ago
please refer to bug 271640.

Password manager exhibits the same behavior as Form/Autocomplete in removing
exact matched items in the list of entries.

Updated

14 years ago
Flags: blocking-aviary1.0?
(Assignee)

Comment 1

14 years ago
Created attachment 159920 [details] [diff] [review]
patch

I'm pretty sure this will fix it, need to test a bit though.
(Assignee)

Updated

14 years ago
Attachment #159920 - Flags: review?(bugs)

Updated

14 years ago
Flags: blocking-aviary1.0? → blocking-aviary1.0+
(Assignee)

Comment 3

14 years ago
checked into trunk and branch.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
(Reporter)

Comment 4

14 years ago
Typing in an exact match in a login field (password manager handled) does show
the list up to the exact match.

But, I'm reopening this bug because of the following issue:

Typing beyond an exact match, then deleting the overtypage back to an exact
match does not show the autofill list.  

note:Deleting one more character (one character short of an exact match) does
then show the autocomplete list. Which is expected.

With form manager, deleting overtypage back to an exact match shows the
autocomplete list as expected. 
Status: RESOLVED → REOPENED
Keywords: fixed-aviary1.0
Resolution: FIXED → ---
(Reporter)

Comment 5

14 years ago
note:  To test this correctly, the login field and its associated password must
have been previously submitted and saved by password manager. That makes the
password manager handle the login field, not the form manager.
Flags: blocking-aviary1.0+ → blocking-aviary1.0-
(Assignee)

Comment 6

14 years ago
Created attachment 161723 [details] [diff] [review]
patch for backspace problem

Thanks. This should fix the backspacing case.
(Assignee)

Updated

14 years ago
Attachment #161723 - Flags: review?(bugs)

Comment 7

14 years ago
This bug seems to have an aviary branch checkin associated with it. If this has
landed on the aviary branch (as much as it's going to for 1.0) can you please
add the "fixed-aviary1.0" keyword? Thanks.
Comment on attachment 161723 [details] [diff] [review]
patch for backspace problem

r=jst
Attachment #161723 - Flags: review?(bugs) → review+

Comment 9

14 years ago
Comment on attachment 161723 [details] [diff] [review]
patch for backspace problem

a=asa for aviary checkin.
Attachment #161723 - Flags: approval-aviary+
(Assignee)

Comment 10

14 years ago
Checked in on the branch.  Leaving bug open until the second patch lands on the
trunk (when the tree reopens).
Keywords: fixed-aviary1.0
the password mgr case in comment 4 now looks like it's working --tested with
2004102508-0.9+ on linux fc2.
(Assignee)

Comment 12

14 years ago
checked in on trunk.
Status: REOPENED → RESOLVED
Last Resolved: 14 years ago14 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.