257317 - Fullscreen window management buttons need tooltips

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Ross Shannon]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040825 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040825 Firefox/0.9.1+

The buttons that appear in the top-right of the window when in fullscreen mode
don't have any tooltips.

On Windows, these need the (localisable) tooltips
* "Minimize"
* "Restore"
* "Close"
...to be in line with IE6.

Reproducible: Always
Steps to Reproduce:
1. Enter fullscreen mode
2. Hover over one of the standard three buttons at the top left of the screen.

Comment 1

[Sekundes]

*** Bug 258823 has been marked as a duplicate of this bug. ***

Comment 2

[Simon Paquet [:sipaq]]

Attachment: Patch v1

Comment 3

[Simon Paquet [:sipaq]]

Attachment: Patch v2

Forgot the ; at the end of tooltip

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 159319 [details] [diff] [review]
Patch v2

>+<!ENTITY fullScreenClose.tooltip "Close">
>+<!ENTITY fullScreenRestore.tooltip "Restore">
>+<!ENTITY fullScreenMinimize.tooltip "Minimize">

Change the order on these so they're not in reverse order, and r=me

Comment 5

[Simon Paquet [:sipaq]]

Attachment: incorporating mconnor's review comments

Comment 6

[Simon Paquet [:sipaq]]

Comment on attachment 159336 [details] [diff] [review]
incorporating mconnor's review comments

Bringing mconnor's review over.

Comment 7

[Steffen Wilberg]

Checked into trunk 2004-09-18 15:24.

Comment 8

[Steffen Wilberg]

Comment on attachment 159336 [details] [diff] [review]
incorporating mconnor's review comments

Would be nice for 1.0.
Has l10n impact because it adds 3 new strings.

Comment 9

[Steffen Wilberg]

I just saw the notice on the aviary tinderbox page.
bsmedberg, this affects l10n. Can you approve this, please?

Comment 10

[Benjamin Smedberg]

asa/chofmann must approve this as well, but I'm ok with it landing as long as it
happens soon.

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 159336 [details] [diff] [review]
incorporating mconnor's review comments

a=asa for aviary checkin.

Please add the late-l10n keyword and notify our localizers in the npm.l10n
newsgroup of this change. thanks.

Comment 12

[Ian Neal]

Checked into aviary.
Checking in base/content/browser.xul;
/cvsroot/mozilla/browser/base/content/browser.xul,v  <--  browser.xul
new revision: 1.228.2.2.2.37; previous revision: 1.228.2.2.2.36
done
Checking in locales/en-US/chrome/browser/browser.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/browser.dtd,v  <-- 
browser.dtd
new revision: 1.1.2.27; previous revision: 1.1.2.26
done