257344 - Remove Exit from common subroutines

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P2)

Description

[Joel Peshkin]

If a routine is called and throws an error, that error ends with exit() instead
of die().  exit() cannot be trapped by an eval {}  while die() can be.  This
means that neither whining nor collectstats can reciver from an error in one
query and continue on to the next query.

Comment 1

[Joel Peshkin]

The way to do this is probably to make a new
Bugzilla->Batch that, if set, causes all the error code to use die() instead of
exit() so errors can be caught.

Comment 2

[Dave Miller [:justdave]]

This has wider implications than just cron scripts.  What about alternative UIs
that need non-HTML error messages?  We really need a much more broadly
encompassing exception mechanism.  See also bug 173626.

Comment 3

[Joel Peshkin]

Attachment: Patch v1 - captures errors to die() if Bugzilla->batch has been called with non-zero argument

Comment 4

[:glob ✱]

Comment on attachment 161114 [details] [diff] [review]
Patch v1 - captures errors to die() if Bugzilla->batch has been called with non-zero argument

r=glob, while the output isn't pretty, it's better than it falling through.

Comment 5

[Joel Peshkin]

This should make Gerv and Erik's existing eval's trap the errors properly.

Comment 6

[Dave Miller [:justdave]]

Comment on attachment 161114 [details] [diff] [review]
Patch v1 - captures errors to die() if Bugzilla->batch has been called with non-zero argument

I'm not sure batch is a good name for this, but "noninteractive" seems too
long, and I can't come up with anything better.  Otherwise this looks nice.

Comment 7

[Joel Peshkin]

Checked in....

Erik, Gerv:  You're on....