Closed Bug 257463 Opened 21 years ago Closed 21 years ago

Localized firefoxes need another Contents/Resources key

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox1.0

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

(Keywords: fixed-aviary1.0, l12y, Whiteboard: [have patch] - ready to land)

Attachments

(1 file, 1 obsolete file)

updated with bug 264498
4.00 KB, patch
MMx
: review+
chofmann
: approval-aviary+
Details | Diff | Splinter Review
Right now, we have Firefox.app/Contents/Resource/English.lproj... there aren't actually any localizable strings in there, but if you don't have a de.lproj in a German build, the system menu will be in English instead of German. So we need to update the build system a bit to move English.lproj to ab.lproj for localized builds. As a quick note, "English" is considered obsolete, the correct dir should be "en" (ISO language code), but I can't imagine Apple ever actually removing support for it.
This is a minor polish bug, and does not affect localized string directly. It would be nice for PR, but don't hold your breath. I can't really make a patch until bug 257117 lands (the patch will be quite simple once I can make it)
Depends on: 257117
Flags: blocking-aviary1.0+
I think this is a dup of Bug 172444.
do we still need this? how critical is it?
Yes, we still need this. Without this, the main Firefox menu and the "Apple" menu stay in English, whereas the rest of the app is localized.
Attached patch Updated from bug 172444 (obsolete) — — Splinter Review
I originally attached this in bug 172444, moving it here with review comments by Martin.
Attachment #162112 - Flags: review?(mmx_bugzilla)
Comment on attachment 162112 [details] [diff] [review] Updated from bug 172444 looks good now, changes from my comment in bug 172444 are incorporated. Lets get this landed so that it is fixed in the localized builds of 1.0RC1.
Attachment #162112 - Flags: review?(mmx_bugzilla) → review+
Attachment #162112 - Flags: approval-aviary?
I found another bug in browser/locales/Makefile.in that prevents the creation of localized Mac builds. I filed under bug 264498 - patch coming up.
Attachment #162112 - Attachment is obsolete: true
Attachment #162196 - Flags: review?(mmx_bugzilla)
Comment on attachment 162196 [details] [diff] [review] updated with bug 264498 review+. This should finally enable localized Mac builds.
Attachment #162196 - Flags: review?(mmx_bugzilla) → review+
Attachment #162112 - Flags: approval-aviary?
Attachment #162196 - Flags: approval-aviary?
Comment on attachment 162196 [details] [diff] [review] updated with bug 264498 a=chofmann
Attachment #162196 - Flags: approval-aviary? → approval-aviary+
Whiteboard: [have patch] - ready to land
Target Milestone: --- → Firefox1.0
Checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
I tested it on my machine and it works fine, lets see how the official nighties turn out.
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: