Problem deleting local folders with forward slashes in the folder name

RESOLVED FIXED in Thunderbird0.9

Status

RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: mscott, Assigned: mscott)

Tracking

({fixed-aviary1.0})

unspecified
Thunderbird0.9
x86
Windows 2000
fixed-aviary1.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
We now allow you to create local folders with forward slashes in them due to Bug
#219586. 

However, if you delete the folder, we create it under Trash, but we aren't
taking into consideration the fact that the folderName contains forward slashes
when we Add the folder to the trash.

Here's a way to re-produce:

"...I am unable to delete this feed at all:
http://rss.news.yahoo.com/rss/oped.  Despite repeated attempts to try to delete
it, it never gets moved to the trash folder.

I have no problem deleting any other Yahoo RSS feeds. This is the only
troublesome one."
(Assignee)

Comment 1

14 years ago
Created attachment 157849 [details] [diff] [review]
possible fix

Possible fix. 

This modifies nsMsgLocalMailFolder::CopyFolderLocal which gets triggered when
we are moving a local rss folder to trash.

Before, we took the folder name (which can now contain slashes), we created a
new folder under trash with that name and then copied the contents over.

This makes us generate a safe hash for the folder name and we use that in our
call to AddFolder. We then set the pretty name appropriately. Furthermore, we
still pass in the regular folder name into CheckIfFolderExists, I didn't change
that. So if you are deleting a folder to trash and we already have a folder in
the trash that has the same name (regardless of the actual disk name), we still
alert you that a folder with that name already exists.
(Assignee)

Comment 2

14 years ago
alternatively we could use the same disk name of the original folder (by getting
the leaf name of the folder path) instead of re-hashing the folder name.
(Assignee)

Comment 3

14 years ago
Comment on attachment 157849 [details] [diff] [review]
possible fix

sr for trunk testing consideration.

See comment #1 and comment #2 for another idea on how we could fix this
Attachment #157849 - Flags: superreview?(bienvenu)

Updated

14 years ago
Attachment #157849 - Flags: superreview?(bienvenu) → superreview+
(Assignee)

Updated

14 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird0.9
(Assignee)

Comment 4

14 years ago
fixed on the branch and the trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.