Closed
Bug 257992
Opened 20 years ago
Closed 19 years ago
Cannot install multiple themes using drag-and-drop to the EM window
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
People
(Reporter: ToddAndMargo, Assigned: robert.strong.bugs)
References
Details
(Keywords: fixed1.8.1)
Attachments
(2 files)
234.68 KB,
image/bmp
|
Details | |
1.11 KB,
patch
|
mconnor
:
review+
asa
:
approval1.8rc1-
robert.strong.bugs
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3 Hi All, I install and maintain a lot of Firefox for my customer base. I carry multiple extensions and themes with me on a CDROM disk. Currently, I have to drag them one at a time into themes and/or extensions to install them. If I select multiple files and themes and drag them into Firefox, none of the themes/extension will install correctly. Would you consider fixing this for me? Many thanks, --Tony aewell@gbis.com Reproducible: Always Steps to Reproduce: 1. 2. 3.
Comment 1•20 years ago
|
||
I am able to drag multiple (>20) extensions to the Extension Manager (Tools>Extensions), and they all get installed properly. You can't drag them to the content area though. Also, you shouldn't drag themes into EM, I think. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040917 Firefox/0.10 Please try it with a more recent build (e.g. 1.0PR), and if you still can't install multiple extensions, please describe what exactly you are doing. Otherwise, resolve this as WORKSFORME. (I suggest that you look at http://home.comcast.net/~ifrit/FFDeploy.html )
Summary: Dragging multiple themes and extensions into FF burps → Cannot drag multiple themes and extensions into FF
Hi asqueella, Thank you for the Deploy link! :-) It looks like the multiple drag on the extensions is fixed. The multiple drag of Themes is still broken. Before you double check my test, download Cute http://enjoy.sytes.net/files/mozilla/fx/Cute_1.9_FX_yop.jar from http://enjoy.sytes.net/mz.htm It is the best theme I have EVER come across. The test I just performed was done on "Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10". But don't pigeon hole yourself into my particular OS. I have reproduced this problem across two county on nearly every flavor of Windows. (Sadly, Linux Firefox does not support dragging themes into the Theme Manager.) This is what I did. 1) Opened Firefox (FF) 2) Opened FF Theme Manager (TM) 3) Opened Windows Explorer and moved to my themes download directory (not a Mozilla directory) 4) Dragged four themes from Windows Explorer into TM 5) Clicked "ok" on all the error messages. (I have attached a low res screen shot.) The error message is as follows: Firefox could not install this theme because "install-tpe.rdf" (provided by the item) is malformed The entries for the crashed theme show the file name ("FireCat_PalePurplePaws-1.0.jar") and not the formal name of the Theme ("FatCat Pale Pirple Paws 1.0"). The crashed theme will also not "uninstall". (A work around for this is to reinstall the themes one-at-a-time, which corrects the crash. Then uninstall them.) --Tony aewell@gbis.com
Comment 4•20 years ago
|
||
Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040924 Firefox/0.10 I tried to install these two simultaneously: 1)Qute and 2)Charamel. I got the same error message as you. There's a message in JavaScript console: "Could not install theme because chrome:name arc in the theme's contents.rdf file (Qute) does not match the em:internalName arc in the theme's install.rdf file (charamel-browser)". Although in the extensions/temp directory, I can see both contents.rdf and install-*.rdf belong to Charamel.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 5•20 years ago
|
||
changing summary to reflect it's a theme-only problem
Summary: Cannot drag multiple themes and extensions into FF → Cannot install multiple themes using drag-and-drop to the EM window
Assignee | ||
Comment 6•19 years ago
|
||
I'm thinking that it may be best to just limit installation of themes to only one at a time or possibly queue them one after the other... e.g. 1st theme install prompt, click ok, install finishes, 2nd theme install prompt, and so on. The reason I believe this to be the way to go is that to allow multiple theme installs at the same time would require significant changes to the code and 1.1 is fast approaching. BTW: Current behavior when installing multiple themes creates non useable entries for all themes installed except one in the theme manager. Regarding the need to be able to install multiple items at once as in the comment #0 with 1.1 it is possible to copy multiple themes and extensions into the extensions directory to install them withtout experiencing this issue... the extension installation dialog is shown for both themes and extensions when installing using this method and it supports installing multiple themes at the same time.
Assignee | ||
Comment 7•19 years ago
|
||
I think this is appropriate for 1.5 since installing more than one theme will leave the extensions datasource in a bad state (e.g. orphaned download items in the datasource and displayed in the ui. If we want to allow multiple theme DnD installs we can come up with a better fix for 2.0.
Assignee | ||
Updated•19 years ago
|
OS: Windows 2000 → All
QA Contact: bugs → extension.manager
Hardware: PC → All
Assignee | ||
Comment 8•19 years ago
|
||
I believe the proper way to fix this is to fix bug 251519
Depends on: 251519
Assignee | ||
Comment 9•19 years ago
|
||
Mike, this is a bit of a pain for a regular user to recover from and though this patch is wallpaper I think it would be a good thing for 1.5. A real fix can be made for the next release in bug 251519 and this can prevent users from getting a corrupt extensions.rdf for 1.5 and then having to ask for help with fixing it. http://forums.mozillazine.org/viewtopic.php?t=330581
Flags: blocking1.8rc1?
Comment 10•19 years ago
|
||
not a blocker but we'd consider a fully reviewed and trunk verified patch for inclusion in the next release (if it happens really quickly). Thanks.
Flags: blocking1.8rc1? → blocking1.8rc1-
Comment 11•19 years ago
|
||
Comment on attachment 197124 [details] [diff] [review] only allow DnD install of one theme get this on trunk ASAP, but this is super-safe...
Attachment #197124 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 12•19 years ago
|
||
Thanks Mike, I'm traveling and will land this around 5 PM Pacific time unless someone beats me to it.
Whiteboard: [checkin needed]
Assignee | ||
Updated•19 years ago
|
Attachment #197124 -
Flags: approval1.8rc1?
Comment 13•19 years ago
|
||
Comment on attachment 197124 [details] [diff] [review] only allow DnD install of one theme not enough user impact to take any change here.
Attachment #197124 -
Flags: approval1.8rc1? → approval1.8rc1-
Assignee | ||
Comment 14•19 years ago
|
||
Checked in on trunk. Asa, as fixes go this is super safe. There may not be many users affected by this but it does happen.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•19 years ago
|
Whiteboard: [checkin needed]
Comment 15•19 years ago
|
||
(In reply to comment #13) > not enough user impact to take any change here. Are you sure? I know lots of people who've fallen into the trap under Fx 1.0 because you can drag and drop multiple extensions and one would naturally think it would be the same for themes. At least under Fx 1.0.x you could uninstall the dud entries but under Fx 1.5 needing to go to the profile folder and delete a certain file is something I wouldn't expect people to know.
Flags: blocking1.8rc2?
Comment 16•19 years ago
|
||
It's too late in the release cycle for non critical show stopper bugs and we already decided to minus this.
Flags: blocking1.8rc2? → blocking1.8rc2-
Comment 17•19 years ago
|
||
Indeed, sorry for asking again.
Comment 18•19 years ago
|
||
(In reply to comment #15) > (In reply to comment #13) > > not enough user impact to take any change here. > Are you sure? I know lots of people who've fallen into the trap under Fx 1.0 > because you can drag and drop multiple extensions and one would naturally think it would be the same for themes. At least under Fx 1.0.x you could uninstall the dud entries but under Fx 1.5 needing to go to the profile folder and delete a certain file is something I wouldn't expect people to know. Michael, I know how and why this dumbass-ity occured such mass spread. Way back in I guess the fall of last year we were plagued by the reputable bug of unable to be installing themes of any kind via the "TM" called Bug 273423 - Can't Install Themes. And god it felt like it lasted an eternity [actually it was around for a good 3 months]. So one user experimented and found out they still could install it via the EM. I'm not so sure it was a 100% fix all solution for everyone back then. But I didn't try it b/c I knew it was going to affect my profile badly somehow whether it created redundant entries in the wrong places [I don't like plain sloppiness for a "quick fix"] or would eventually corrupt my extensions.rdf then or in the future. Whatever the reason, I was very profile religious back then and still am now. So that's how that user error-bility came about. I don't think any one would do this unless they were plain lazy. Btw, isn't that the reason we have the two separate managers in the first place? Among the other obvious reasons I shouldn't have to mention in the 1st place (security (I mean let's try to install a [malicious] plugin there too while we're at it), cleanliness, organization, easier to narrow down bugs in the future, etc). I strongly am against this. EM is for extensions. TM is for themes. If you can do this what this user is proposing, then you'd have less ease incorporating my "Cancel" button feature for users accidentally stumbling into the Toolbars customize dialog w/o having to forfeit their prefs to exit [which I'm about to plug: Bug 174957] respectfully. The more sane thing would be to, unless this already hasn't been done [I haven't used a new build in over 4 months now, except for less that a couple minutes at a time a friend's house to see if the all the old issues I remember were addressed much less have any time left to check if any new features were added], that we add keyboard shortcuts for each the EM & TM. I don't know which those would be at this time. Considering, Ctrl+T is new tab and is Ctrl+E still search b/c I thought it also had Ctrl+K? Which is a bit repetitous in my mind unless one clearly does something the other doesn't; maybe it was CTRl+K plus selection from webpage would search added keywords and Ctrl+E would focus Search Bar? So how about Ctrl+F1 and so on? I mean until a better combo is found. Cause let's face it, it's not liking I'm jumping on FF everyday just to hit Ctrl+Shift+G. One of my least favortie combos. Or just plain shift+T or shift+F1 & F2 (I realize F3 & F6 are utilized)?
Assignee | ||
Updated•18 years ago
|
Attachment #197124 -
Flags: approval-branch-1.8.1+
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•