251519 - Extensions / themes installed while another one is still downloading do not install correctly

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Thomas Rutter]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040712 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040712 Firefox/0.9.1+

When you install a theme, it is placed into the Theme manager and while it is
downloading you can see a progress bar.

If you try to install another theme while this is downloading, the downloading
theme will appear broken.

Reproducible: Always
Steps to Reproduce:
1. Install a theme from updates.mozilla.org, such as FirefoxModern
2. While the theme is still downloading, install another theme, such as Qute

Actual Results:  
The download progress bar for the FirefoxModern theme disappears.  Clicking on
the entry for FirefoxModern theme will display an error indicating that
FirefoxModern does not have any preview image.

Expected Results:  
Show both of the themes with download progress bars.  Allow the themes to
download at the same time.

Comment 1

[Asa Dotzler [:asa]]

This would be nice to fix for 1.0. It's somewhat confusing to users who might
think the other theme has finished downloading when it hasn't. 

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Not as important as other EM problems. 

Comment 3

[sairuh (rarely reading bugmail)]

I think I've encountered this (occaisionally) in the past while concurrently
installing and downloading themes or extensions. will post test case if I can
get a reproducible recipe.

Comment 4

[Robert Strong (they/them - no direct email)]

This is the same problem as bug 257960 though extensions get the invalid package
warning from xpinstall whereas themes do not.

Comment 5

[Robert Strong (they/them - no direct email)]

*** Bug 257960 has been marked as a duplicate of this bug. ***

Comment 6

[Robert Strong (they/them - no direct email)]

Bug 319022 changed the behavior of this bug on the trunk - on the MOZILLA_1_8_BRANCH as well after the patch in bug 319022 is checked in there. Now, after the first install completes the second install's progress bar disappears as before but it completes successfully. So, this is a visual glitch at this time with the install completing successfully.

Comment 7

[Robert Strong (they/them - no direct email)]

This has changed significantly since it was first reported especially now on the trunk with the new ui... I'd appreciate it if someone could test out different scenarios on the trunk and report back their findings. Thanks

Comment 8

[Robert Strong (they/them - no direct email)]

If someone could QA this bug I might be able to fix it for beta 2. Specifically I need someone to test different multiple install scenarios for both extensions and themes and to report findings back in this bug.

Comment 9

[Robert Strong (they/them - no direct email)]

This bug as originally reported was fixed by the checkin of bug 319022. I believe there is still a visual glitch as described in comment #6 which if present should be a new bug. Resolving -> wfm.