258091 - Entering Fullscreen (F11) and exiting browser with more than 1 tab open does not cause popup notification to show up

Status: VERIFIED DUPLICATE of bug 283987

(Firefox :: Tabbed Browser, defect)

Description

[Ricardo]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3

Entering Fullscreen mode and trying to exit with more than one tab open does not
cause the "There are x tabs open. Are you sure you want to exit blabla" popup
message to show up.

Reproducible: Always
Steps to Reproduce:
1. Enter Fullscreen by pressing F11
2. Open more than 1 tab using the CTRL+T shortcut
3. Exit browser (by clicking on the X in the top right corner :P)

Actual Results:  
The confirmation message doesn't show up

Expected Results:  
The message telling that I have X tabs open and asking if I really wanted to exit.

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20040905
Firefox/1.0 PR (NOT FINAL)

Confirming, ctrl+shift+W closes the browser with multiple tabs, no questions asked.
(it does the same in the normal screen mode though)

maybe F11 should check browser.tabs.warnOnClose

->NEW

Comment 2

[Peter van der Woude [:Peter6]]

oops, F11 comment is rubbish, should have been

maybe ctrl+shift+W should check browser.tabs.warnOnClose

Comment 3

[Simon Paquet [:sipaq]]

Bringing up the popup notification is easy. 

You just have to replace the window.close() function in
http://lxr.mozilla.org/seamonkey/source/browser/base/content/browser.xul#393 or 
http://lxr.mozilla.org/aviarybranch/source/browser/base/content/browser.xul#368

with the WindowIsClosing() function from 
http://lxr.mozilla.org/seamonkey/source/browser/base/content/browser.js#4741 or 
http://lxr.mozilla.org/aviarybranch/source/browser/base/content/browser.js#5480

this brings up the popup notification in an aviary-build. The problem is that
clicking on "Close Tabs" in the popup notification does not close the application.

I don't know the reason. An educated guess would be that the WindowIsClosing()
function is not fullscreen-aware if there is such a thing. Looking at CVS blame
suggests that jst wrote the corresponding code. He checked it in at 2004-02-19
13:52. I hope someone can make something out of that information.

Comment 4

[Mikko Virkkilä]

Also happens on Linux 

Comment 5

[Florian Quèze [:florian]]

*** This bug has been marked as a duplicate of 283987 ***