283987 - No warning when closing multiple tabs in full screen (close button)

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Kieran Britton]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050227 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050227 Firefox/1.0+

the confirm close warning doesn't appear when you push the close button, it
works with alt+f4

Reproducible: Always

Steps to Reproduce:
1.open 2 or more tabs
2.go into full screen
3.push close button

Actual Results:  
closes without confirm close warning

Expected Results:  
shown confirm close warning

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050227
Firefox/1.0+

I'm not seeing a "close window button" in fullscreen mode (no titlebar)
Alt-F4 and ctrl+shift+W are the only ways I can close it and they both cause the
close dialog to show.

Comment 2

[Kieran Britton]

(In reply to comment #1)
> I'm not seeing a "close window button" in fullscreen mode (no titlebar)

top right, the x

Comment 3

[Peter van der Woude [:Peter6]]

That's just to close 1 tab at the time

Comment 4

[Kieran Britton]

Attachment: screen shot

this might make it clearer

Comment 5

[Kieran Britton]

The close button (id="close-button") uses "window.close();".
If I change it to "goQuitApplication();" it shows the confirm close dialog

Comment 6

[Kieran Britton]

Actually "BrowserTryToCloseWindow()" is better

Comment 7

[José Jeria]

Confirming with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050228 Firefox/1.0+

Pressing the close button in fullscreen shuts down Firefox without any dialog.

Comment 8

[:Mook]

Attachment: Patch as described by Kieran Britton in comment #5 #6

This does seem to fix this (using the same method File -> Close Window uses). 
Patch as described by Kieran Britton in comment #5 and comment #6, but in CVS
diff form so it can be reviewed.

(I don't think any of us have CVS privs; mconnor, if this gets r+, please check
in for us; thanks.  Assuming no sr for browser.)

Comment 9

[:Gavin Sharp [email: [e-mail]]]

*** Bug 288772 has been marked as a duplicate of this bug. ***

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 178849 [details] [diff] [review]
Patch as described by Kieran Britton in comment #5 #6

a=asa

Comment 11

[Asaf Romano (gone)]

Checking in browser.xul;
/cvsroot/mozilla/browser/base/content/browser.xul,v  <--  browser.xul
new revision: 1.261; previous revision: 1.260
done

Comment 12

[Kevin Brosnan]

*** Bug 294797 has been marked as a duplicate of this bug. ***

Comment 13

[:Gavin Sharp [email: [e-mail]]]

*** Bug 296472 has been marked as a duplicate of this bug. ***

Comment 14

[:Mook]

*** Bug 296548 has been marked as a duplicate of this bug. ***

Comment 15

[Sean Craig]

(In reply to comment #14)
> *** Bug 296548 has been marked as a duplicate of this bug. ***

This bug has not been resolved as of Firefox 1.0.4. Is there a timeline as to
when this will be implemented?

Comment 16

[José Jeria]

(In reply to comment #15)
> This bug has not been resolved as of Firefox 1.0.4. Is there a timeline as to
> when this will be implemented?

This was fixed after 1.0.4, it will be working as expected in Firefox 1.1

Comment 17

[Kevin Brosnan]

*** Bug 297659 has been marked as a duplicate of this bug. ***

Comment 18

[Florian Quèze [:florian]]

*** Bug 258091 has been marked as a duplicate of this bug. ***

Comment 19

[:Gavin Sharp [email: [e-mail]]]

*** Bug 303667 has been marked as a duplicate of this bug. ***

Comment 20

[Dave Townsend [:mossop]]

*** Bug 304618 has been marked as a duplicate of this bug. ***

Comment 21

[Dave Townsend [:mossop]]

*** Bug 306357 has been marked as a duplicate of this bug. ***