258277 - Add menu item to Check for Updates

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect, P1)

Description

[alanjstr]

Right now we have to go to different screens to check for various updates.  If
someone has disabled automatic checking, they might still want to use the web
service.  A menu item under Tools should be created to "Check for Updates"

Comment 1

[Andre-John Mas]

This would be of interest, though I am not sure the 'Tools' menu is the best
place? On MacOS X a number of programs, such as Fire, provide a 'check for
update' link in the application menu (the one with application's name on it). On
other platforms I believe its added to the help menu.

Where ever it is put will probably depend on the platform, since it should be in
a location that users of the platform would expect to find it.

Note: I would be tempted to change the OS to all.

Comment 2

[alanjstr]

This seems even more important with the recent security hole/patch released for
0.10.1.  Navigating through the various menus is cumbersome just to check for
updates.

Comment 3

[Benjamin Smedberg]

Do strings for this already exist, or would we need to add new ones?

Comment 4

[alanjstr]

Tools -> Options -> Advanced -> Software Update/Check Now

We could just go with the "Software Update" title if we didn't want to create
something new, if even for the 1.0 milestone.

Comment 5

[Ryan Polk (Quark)]

Removing blocking-aviary1.0mac?

Either this should go in for all 1.0, or none of them.

Comment 6

[Doron Rosenberg (IBM)]

On windows, some apps have it under the help menu

Comment 7

[Doron Rosenberg (IBM)]

Attachment: patch

I don't have a mac, so didn't write the code to move the item to the
application menu.

Comment 8

[Seb]

You should also be able to specify the autoupdate "frequency" (run every X
hours/days/months)

Comment 9

[Doron Rosenberg (IBM)]

(In reply to comment #8)
> You should also be able to specify the autoupdate "frequency" (run every X
> hours/days/months)

That is what preferences/options is for.

Comment 10

[Mike Kaply [:mkaply]]

Javier - have some fun.

Comment 11

[jhp (no longer active)]

Attachment: patch v1.1

Updated patch to trunk.  Made Update menu item hidden by default on Mac, and
changed text to "Check for Updates...", since this also checks for extension
updates.

Comment 12

[jhp (no longer active)]

Attachment: mac only patch

This patch adds the 'Update' menu item to the application menu on Mac.

Comment 13

[Asaf Romano (gone)]

Let's move the mac "backend" part to another bug, abusing the mac menu code for
a  particular menu item isn't the Right Thing.

Comment 14

[Mike Connor [:mconnor]]

Comment on attachment 179071 [details] [diff] [review]
patch v1.1

This really doesn't belong in the Help menu, it should be under Tools, afaict. 
Reading the Windows/GNOME UI guides, its really specific that this should be
"help documents" and the About dialog only.

IE has their update link under Tools, as does Real Player.  There's some that
use Help, but that's no excuse for co-opting a clearly specified menu.

Comment 15

[Doron Rosenberg (IBM)]

over to me.  We will be doing a regular, tools menuitem for all platforms untill
the mac people do a generic way to get items into the app menu.

Comment 16

[Doron Rosenberg (IBM)]

Attachment: use the tools menu

I have it right under the Theme Manager, feel free to suggest a better location
in the menu.

Comment 17

[Mike Kaply [:mkaply]]

Comment on attachment 181149 [details] [diff] [review]
use the tools menu

a=mkaply

Comment 18

[Doron Rosenberg (IBM)]

fixed - want to keep this open for the mac stuff?

Comment 19

[jhp (no longer active)]

-> FIXED

Mac specific issues are handled in bug 288322.

Comment 20

[José Jeria]

When clicking on this menu item, the green update available arrow icon will
appear on the top right.

This is confusing, since you then believe there is an update, but the update
dialog tells you there is none. When closing the dialog, the green arrow goes
away. File new bug for this?

Comment 21

[Doron Rosenberg (IBM)]

yes, please file a separate bug.

Comment 22

[José Jeria]

(In reply to comment #21)
> yes, please file a separate bug.

Bug 291302 filed

Comment 23

[u88484]

The tools menu looks to clutterd now with all the seperators. How about moving
'Check for Updates' to the top so its the first option in the tools menu, no
seperator after it so its just 'Check for Updates' and 'Web Search' in the "same
space"

Comment 24

[Doron Rosenberg (IBM)]

mconnor says that they will do a menu cleanup for 1.1 at some point, and then
the item can be moved.  This bug is about getting the code written :)

Feel free to talk to him about it and if you decide something, file a new bug.

Comment 25

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381