258553 - Site icon (favicons) vertically mis-aligned in location bar when changing system font size

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.2) Gecko/20040825 Camino/0.8.1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.2) Gecko/20040825 Camino/0.8.1

Favicons (and the globe and document icons for sites and local files) are
vertically "mis-aligned" in the location bar--aligned to the bottom of the bar
rather than centered like the URL text, leaving excess white space above the
favicon and almost making the favicon look like it is covered up by the grey
"border" on the bottom.  It's visually distracting (but trivial) :-)

Reproducible: Always
Steps to Reproduce:
1.  Open Camino
2.  Look at the Location bar
3.

Actual Results:  
Globe/favicon vertically aligned with the bottom of the location bar

Expected Results:  
Globe/favicon should be vertically centered in location bar, along with URL
text--which is centered.

Mac OS X 10.3.5, Camino 0.8.1

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: small screenshot of the relevant area

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I just noticed this mis-alignment occurs in the tabs, too (it's less
noticeable).  Does that need a separate bug?

Comment 3

[Jasper]

Never seen this, never heard of it. Pleas dl a new build of Camino and try again.
WFM

Comment 4

[Jasper]

Seems this is caused by the user changing the system font size.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Favicon overlaps the focus ring/highlight

Ah...yes, I had decreased a couple of font sizes by one point via TinkerTool
when I first got OS X.	It helped with Apple's UI size bloat but I'd never seen
an ill effect--until now.

Here's an even better illustration from the 20040925 build.

(Jasper, what does "WFM" mean?)

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Having spent some time now helping try to triage, dupe, reproduce, etc., other
bugs, I think the summary would be more useful if it reflects the cause that
Jasper discovered.  So changing the summary to add "when system font size changed."

Sorry for the interruption.

Comment 7

[Simon Fraser [no longer active]]

How do you change the system font size? Is there UI to do this?

Comment 8

[Jasper]

No there is no UI for this in the system, people do this using Haxies I guess.
I'm in favour of WONTFIXING this bug. This probably only happens to 0.5% of our
users.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

A number of 3rd party tools such as TinkerTool provide the UI for this; it's not
haxie-based, but a hidden system pref (so it probably can be set from the
command-line as well); TinkerTool does not provide any features that are not
already present in OS X.

What I don't understand is why the text remains vertaically centered but the
icons do not....

Comment 10

[Wevah (Nate Weaver)]

(In reply to comment #9)
> What I don't understand is why the text remains vertaically centered but the
> icons do not....

I think it's because we rely on inheritance from NSTextFieldCell to draw the
text, but we draw the image ourselves.

Comment 11

[Mike Pinkerton (not reading bugmail)]

let's see how important this becomes as tiger includes the ability to scale the
ui for ally and higher resolution displays.

Comment 12

[Simon Fraser [no longer active]]

(In reply to comment #11)
> let's see how important this becomes as tiger includes the ability to scale the
> ui for ally and higher resolution displays.

Ha ha, we're totally hosed if the UI resolution is not 1.0, because NSQuickDrawView doesn't support it. (To experiment, run Quartz Debug and hit Command-U.)

Comment 13

[Desmond Elliott]

I have re-assigned this because it is not an immediate priority and is a good first bug

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 351392 has been marked as a duplicate of this bug. ***

Comment 15

[jonathan chetwynd]

I hardly think #351392 is a dupe,as the scope is wider and there is a request for a dialogue in the meantime.

changing summary to reflect these differences

Comment 16

[froodian (Ian Leue)]

Reinserting critical search keywords, and removing irrelevent implementation details.  Things like "adding a dialog" should be discussed when the bug is up for fixing, not argued in the summary of a bug.