Closed Bug 258707 Opened 20 years ago Closed 20 years ago

fix base vs. sheet URI and line numbers for sub-sheet parsing

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.8alpha4

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Whiteboard: [patch])

Attachments

(1 file, 1 obsolete file)

This is a followup to bug 255538 (and bug 240420).  I need to:
 * figure out what the correct sheet URI to use for the 4 XXX comments cited in
bug 255538 comment 4.
 * make those for which we don't have usable line numbers use line '0' instead
of line '1' and make line 0 be a magic non-incrementing line number (in case
scripts introduce line breaks)
Attached patch patchSplinter Review
Attachment #158463 - Attachment is obsolete: true
Attachment #158465 - Flags: superreview?(bzbarsky)
Attachment #158465 - Flags: review?(bzbarsky)
Comment on attachment 158465 [details] [diff] [review]
patch

>Index: xul/content/src/nsXULElement.cpp
>+        // XXX Get correct Base URI (need GetBaseURI on *prototype* 

Could you please file a bug on this?  I don't think we have one...

r+sr=bzbarsky
Attachment #158465 - Flags: superreview?(bzbarsky)
Attachment #158465 - Flags: superreview?
Attachment #158465 - Flags: superreview+
Attachment #158465 - Flags: review?(bzbarsky)
Attachment #158465 - Flags: review?
Attachment #158465 - Flags: review+
Fix checked in to trunk, 2004-09-10 16:31 -0700.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: [patch]
Target Milestone: --- → mozilla1.8alpha4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: