Closed
Bug 258712
Opened 21 years ago
Closed 21 years ago
whine.pl should honour emailsuffix
Categories
(Bugzilla :: Whining, defect, P3)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.20
People
(Reporter: Wurblzap, Assigned: Wurblzap)
References
Details
Attachments
(1 file)
|
609 bytes,
patch
|
erik
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; de-DE; rv:1.7) Gecko/20040707 Firefox/0.9.2
Build Identifier: Bugzilla 2.19
This is a follow-up bug of bug 256762.
Reproducible: Always
Steps to Reproduce:
| Assignee | ||
Comment 1•21 years ago
|
||
Comment 2•21 years ago
|
||
Are you sure that this is enough?
Bugzilla/User.pm contains:
sub login { $_[0]->{login}; }
sub email { $_[0]->{login}; }
One probably needs to change the latter into
sub email { $_[0]->{login}.Param('emailsuffix'); }
Or do I miss something?
Status: UNCONFIRMED → NEW
Ever confirmed: true
| Assignee | ||
Comment 3•21 years ago
|
||
(In reply to comment #2)
> sub email { $_[0]->{login}.Param('emailsuffix'); }
This happens in bug 255913. That's why there's a dependency and why I didn't
request review yet.
| Assignee | ||
Updated•21 years ago
|
Attachment #158411 -
Flags: review?
Comment 4•21 years ago
|
||
Comment on attachment 158411 [details] [diff] [review]
Use Bugzilla::User::email()
>diff -x CVS -x data -r -u3 orig/template/en/default/whine/multipart-mime.txt.tmpl patched/template/en/default/whine/multipart-mime.txt.tmpl
>--- orig/template/en/default/whine/multipart-mime.txt.tmpl 2004-08-04 23:36:28.000000000 +0200
>+++ patched/template/en/default/whine/multipart-mime.txt.tmpl 2004-09-10 01:46:30.000000000 +0200
This patch doesn't apply cleanly. It only affects one file, so it was easy
enough to apply, but if there were more to it, I'd ask that you re-generate it
using "cvs diff." No big deal in this case.
Works great, though. Not a heck of a lot of moving parts.
This should go into 2.19
Attachment #158411 -
Flags: review? → review+
Updated•21 years ago
|
Flags: blocking2.20?
Updated•21 years ago
|
Priority: -- → P3
Target Milestone: --- → Bugzilla 2.20
Version: unspecified → 2.19
Updated•21 years ago
|
Assignee: erik → wurblzap
Flags: approval?
Updated•21 years ago
|
Flags: blocking2.20?
Flags: blocking2.20+
Flags: approval?
Flags: approval+
Comment 5•21 years ago
|
||
Checking in template/en/default/whine/multipart-mime.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/whine/multipart-mime.txt.tmpl,v
<-- multipart-mime.txt.tmpl
new revision: 1.2; previous revision: 1.1
done
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•