258712 - whine.pl should honour emailsuffix

Status: RESOLVED FIXED

(Bugzilla :: Whining, defect, P3)

Description

[Marc Schumann [:Wurblzap]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; de-DE; rv:1.7) Gecko/20040707 Firefox/0.9.2
Build Identifier: Bugzilla 2.19

This is a follow-up bug of bug 256762.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Use Bugzilla::User::email()

Comment 2

[Tobias Burnus]

Are you sure that this is enough?

Bugzilla/User.pm contains:
  sub login { $_[0]->{login}; }
  sub email { $_[0]->{login}; }

One probably needs to change the latter into
  sub email { $_[0]->{login}.Param('emailsuffix'); }
Or do I miss something?

Comment 3

[Marc Schumann [:Wurblzap]]

(In reply to comment #2)
>   sub email { $_[0]->{login}.Param('emailsuffix'); }

This happens in bug 255913. That's why there's a dependency and why I didn't
request review yet.

Comment 4

[Erik Stambaugh]

Comment on attachment 158411 [details] [diff] [review]
Use Bugzilla::User::email()

>diff -x CVS -x data -r -u3 orig/template/en/default/whine/multipart-mime.txt.tmpl patched/template/en/default/whine/multipart-mime.txt.tmpl
>--- orig/template/en/default/whine/multipart-mime.txt.tmpl	2004-08-04 23:36:28.000000000 +0200
>+++ patched/template/en/default/whine/multipart-mime.txt.tmpl	2004-09-10 01:46:30.000000000 +0200

This patch doesn't apply cleanly.  It only affects one file, so it was easy
enough to apply, but if there were more to it, I'd ask that you re-generate it
using "cvs diff."  No big deal in this case.

Works great, though.  Not a heck of a lot of moving parts.

This should go into 2.19

Comment 5

[Vlad Dascalu]

Checking in template/en/default/whine/multipart-mime.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/whine/multipart-mime.txt.tmpl,v
 <--  multipart-mime.txt.tmpl
new revision: 1.2; previous revision: 1.1
done