256762 - flag request email doesn't use emailsuffix

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Dylan Simon]

User-Agent:       Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7) Gecko/20040809 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7) Gecko/20040809 Firefox/0.9.3

Bugzilla/Flag.pm using template/en/default/request/email.txt.tmpl fails to
append emailsuffix to to_email.

Reproducible: Always
Steps to Reproduce:
Set emailsuffix to @domain.com.
Have users login with just user names.
Request a flag to be set from someone.
Actual Results:  
Email didn't get sent correctly: went to user (without email suffix).

Expected Results:  
Email should have been sent to user@emailsuffix.

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Btw, it seems to me that the votesremoved code in globals.pl suffers from the
same ailment. Is there a bug for this?

Comment 2

[Christian Reis]

Seems to be happenning here too.

Comment 3

[Christian Reis]

Comment on attachment 157157 [details] [diff] [review]
Patch

Looks correct (but I haven't tested on my tree). 

Note that whine.pl seems to have a similar issue at least. I suspect
importxml.pl does as well.

Comment 4

[Christian Reis]

Raising severity as this results in an inability to use flag notifications with
emailsuffixes.

Comment 5

[Vlad Dascalu]

Checking in Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.21; previous revision: 1.20
done

Checking in Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.18.2.2; previous revision: 1.18.2.1
done

Comment 6

[Vlad Dascalu]

kiko, Marc, comment #3: can you confirm that the problem exists in whine.pl or
importxml.pl, or/and open a bug/bugs about that one in order to keep it on the
radar?

Thanks!

Comment 7

[Marc Schumann [:Wurblzap]]

Follow-up bugs are bug 258709, bug 258711 and bug 258712.

Comment 8

[Tyler]

Perhaps i'm insane, but this patch does not work for me. I applied against 2.18rc2.

Further, i don't see how it can work. I'm attaching my own patch that does work
for my installation. Comments as to what's going on are appreciated.

Comment 9

[Tyler]

Attachment: alternate fix for flag emailsuffix

Comment 10

[Peter Kay]

I looked at the patch in comment 3, and after hitting my head against it for a
while, finally realized that it's in an if block:

if ($flag->{'target'}->{'bug'}->{'restricted'}
        || $flag->{'target'}->{'attachment'}->{'isprivate'})

Since, in my case, it's neither private nor restricted, this isn't helping.

Tyler's fix looks much better.

Um...I can't reopen this bug.  Someone?

Comment 11

[Marc Schumann [:Wurblzap]]

(In reply to comment #10)

Peter, I think the patch is correct. It does not change the fact that cc list
members do not get a notification under certain conditions. What it does change
is that if they do get a notification, then the emailsuffix is appended to their
logins to build their full e-mail addresses.

Is it possible that what you're seeing is a different bug?

Comment 12

[Peter Kay]

I just checked the latest CVS, to make sure I wasn't missing anything:

Assume 1. the bug is not restricted, 2. the attachment is not private, and 3.
that the flag does have a 'cc_list' (say, "pkay").  All these conditions are met
in my installation.

In sub notify, the if() {} block that contains
    push(@new_cc_list, $cc.Param('emailsuffix'));
is not executed (1 and 2 above), $flag->{'type'}->{'cc_list'} is not updated,
and Bugzilla happily tries to send e-mail to "pkay" (3 above) - which bounces,
as there is no local user "pkay".  I can show you the bounce messages, if you
like :)

Comment 13

[Marc Schumann [:Wurblzap]]

Now I get it :)

The thing is that flags' cc lists are not bugzilla logins but simple free e-mail
addresses (see
http://www.bugzilla.org/docs/tip/html/flags-overview.html#flags-create-field-cclist).
This was new to me, I admit.
This means that
 - my patch is wrong (I filed bug 277389 to correct that) and
 - you should put full e-mail addresses into your flag's cc list field.

Comment 14

[Peter Kay]

I guess this should be "INVALID" not "FIXED", huh?

That took me by surprise, too - I hadn't read the manual, myself.

Thanks, Marc!

Comment 15

[Marc Schumann [:Wurblzap]]

(In reply to comment #14)
> I guess this should be "INVALID" not "FIXED", huh?

Requestee and setter still need the emailsuffix, the patch is right on that account.
Even without that, there is a patch on this bug which has been checked in, so
the bug is, by definition, fixed :/