Print preview should hide the browser statusbar

RESOLVED FIXED in Firefox1.0

Status

()

Firefox
General
RESOLVED FIXED
14 years ago
12 years ago

People

(Reporter: Jim Ginn, Assigned: Jim Ginn)

Tracking

({fixed-aviary1.0})

1.0 Branch
Firefox1.0
fixed-aviary1.0
Points:
---
Bug Flags:
blocking-aviary1.0 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.09 KB, patch
mconnor
: review+
Details | Diff | Splinter Review
(Assignee)

Description

14 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040911 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040911 Firefox/0.10

Currently when a user selects Print Preview, the statusbar for the previewed
page remains visible. This means that the user can create live bookmarks, change
pop-up settings, and switch stylesheets (bug 258800) using the statusbar icons -
which really have nothing to do with printing and, thus, is confusing to the
user. The only reason currently for showing the statusbar might be to show that
the page is secure, but the user should be aware of this before even printing.
For what it is worth, IE hides the statusbar.

Reproducible: Always
Steps to Reproduce:
1.Visit a site that triggers a statusbar icon (like http://www.mozilla.org/).
2.Select Print Preview.

Actual Results:  
You can still access the statusbar icon (in the case of mozilla.org you can set
a live bookmark).

Expected Results:  
Hidden access to any site triggered statusbar icons.

Another acceptable option would be to follow the approach in bug 258800 and
leave the statusbar visible, but collapse all of the icons. This would also
allow for the security icon to remain visible, if desired.

This is also similar to bug 257178.
(Assignee)

Updated

14 years ago
Flags: blocking-aviary1.0?

Updated

14 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 1

14 years ago
unlikely that there is time to get this into 1.0 -- renominate if a patch appears.
Flags: blocking-aviary1.0? → blocking-aviary1.0-
(Assignee)

Comment 2

14 years ago
Created attachment 160504 [details] [diff] [review]
patch

This patch will hide the status-bar when you go into print preview. I have
tested it by manually applying the patch and have not run into to problems. I
don't have much programming experience (at least not in programming for
applications), so this diff was blatantly stolen from bug 258800.
(Assignee)

Comment 3

14 years ago
Renominating as there is now a patch. On a side note, how do I make a review
request?
Flags: blocking-aviary1.0- → blocking-aviary1.0?
(Assignee)

Comment 4

14 years ago
Also, if this patch gets checked in, you might want to update the comments:

  //   (*) sidebar
+ //   (*) statusbar
  //   (*) find bar

Comment 5

14 years ago
So why don't you update your patch with the added comment?
You should call it "statusbar", not "statusbars".
For bonus points, create your patch with "cvs diff -up8". '8' is for additional
context, and 'p' shows the function your changes are in.

To make a review request, click on Edit next to the patch, set "review" to "?"
and add the requestee in the textbox. The list of Firefox reviewers is here:
http://www.mozilla.org/projects/firefox/review.html
Choose on of the first three, or mconnor@steelgryphon.com.
(Assignee)

Comment 6

14 years ago
Created attachment 160537 [details] [diff] [review]
updated patch

Thanks Steffen for your help - I think I have covered all of your concerns with
this patch. I have never used CVS before (or a diff for that matter), so this
is a bit of a learning experience for me. If I have made any more mistakes,
please let me know.
Attachment #160504 - Attachment is obsolete: true
(Assignee)

Updated

14 years ago
Attachment #160537 - Flags: review?(mconnor)
Comment on attachment 160537 [details] [diff] [review]
updated patch

I can live with this.  agree that its kinda pointless.
Attachment #160537 - Flags: review?(mconnor)
Attachment #160537 - Flags: review+
Attachment #160537 - Flags: approval-aviary?

Comment 8

14 years ago
*** Bug 258800 has been marked as a duplicate of this bug. ***

Comment 9

14 years ago
Transferring Asa's blocking-aviary1.0+ from the dupe.
Flags: blocking-aviary1.0? → blocking-aviary1.0+
Target Milestone: --- → Firefox1.0
Version: unspecified → 1.0 Branch

Comment 10

14 years ago
Comment on attachment 160537 [details] [diff] [review]
updated patch

a=asa for aviary checkin.
Attachment #160537 - Flags: approval-aviary? → approval-aviary+

Updated

14 years ago
Whiteboard: [patch ready to be checked in]

Comment 11

14 years ago
-> Jim.
Assignee: firefox → vertigo451

Comment 12

14 years ago
Checked in branch & trunk 2004-10-01 15:10 / 16:46.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Whiteboard: [patch ready to be checked in]
You need to log in before you can comment on or make changes to this bug.