259083 - Error in Close Tab shortcuts

Status: VERIFIED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Patrick]

In the help index, clicking on KEYBOARS SHORTCUTS brings up "Firefox Keyboard
Shortcuts"

The current help file states

Command  	Firefox  	Internet Explorer  	Opera

Close Tab  	Ctrl+W          Ctrl+W
                Ctrl+F4 	Ctrl+F4 	 

Clearly, IE doesn't support tabbed browsing and the IE shortcuts were meant to
go under Opera.

Comment 1

[Sean Umphlet (nosebleed)]

Attachment: This is just a simple one-line fix

Comment 2

[Steffen Wilberg]

Comment on attachment 158749 [details] [diff] [review]
This is just a simple one-line fix

>       <td>Close Tab</td>
>       <td><kbd>Ctrl</kbd>+<kbd>W</kbd><br/>
>         <kbd>Ctrl</kbd>+<kbd>F4</kbd></td>
>+      <td>&nbsp;</td>
>       <td><kbd>Ctrl</kbd>+<kbd>W</kbd><br/>
>         <kbd>Ctrl</kbd>+<kbd>F4</kbd></td>
>       <td>&nbsp;</td>
You need to delete the last line if you don't want to add another column.

Comment 3

[Sean Umphlet (nosebleed)]

Attachment: Removed last column. oops

Oops. I didn't see that last column. Line removed. :-)

Comment 4

[Sean Umphlet (nosebleed)]

Attachment: err, this is the patch

Seems I uploaded the wrong file. Sorry for the bugspam.

Comment 5

[Steffen Wilberg]

Comment on attachment 158751 [details] [diff] [review]
err, this is the patch

I first thought you uploaded the same file again. Then I saw you deleted the
last line from your patch. That won't do. The patch won't even apply, because
the number of lines removed/added doesn't match anymore (although I didn't try
it).
You need to edit shortcuts.xhtml, delete that line there, and create a new
patch. :)

Take your time, it looks like we're missing 1.0PR anyway, because that's going
to be released tomorrow and only critical patches will be allowed.

Comment 6

[Mike Connor [:mconnor]]

as a note, help contents aren't the same as l10n impacting.  If we have wrong
content, we can fix it without regard to whether the translators will do stuff
differently, since hopefully they will do stuff right themselves. ;)

Comment 7

[Sean Umphlet (nosebleed)]

Attachment: This patch works

OK, I'm absolutely sure this patch works. I checked and double-checked. :-)

Comment 8

[Sean Umphlet (nosebleed)]

Attachment: This patch works, sorry

Bleh, uploaded the wrong file, again.

Comment 9

[Steffen Wilberg]

Comment on attachment 158815 [details] [diff] [review]
This patch works, sorry

Exactly. I'll land this as soon as the branch tree reopens.

Comment 10

[Steffen Wilberg]

Checked into br & trunk.

Comment 11

[Steffen Wilberg]

*** Bug 264125 has been marked as a duplicate of this bug. ***