Closed Bug 259861 Opened 16 years ago Closed 9 years ago
Should log errors on bindings with no id attribute
See bug 255715 comment 8 and following.
Whiteboard: [good first bug]
The stated dependencies of this bug are status FIXED what needs doing here next? Create a LogError( "errTag" ) function? What about Bug 228205?
What needs to happen is adding an appropriate call to nsContentUtils::ReportToConsole when this error is encountered (along with a string addition to content/xbl/src/xbl.properties). Bug 228205 isn't as relevant here because nsContentUtils is abstracting away a good bit of the api.
I know that this bug is old enough, but it's really annoying. I have changed ConstructBinding method signature to accept line number to show it in error message.
Attachment #512210 - Flags: review?(bzbarsky)
Comment on attachment 512210 [details] [diff] [review] Error message added r=me. Thank you for doing that! Unfortunately, the tree is locked down for the Gecko 2.0 release right now; I'll make sure to get this checked in as soon as it reopens. It'll be a few weeks. :(
Attachment #512210 - Flags: review?(bzbarsky) → review+
Assignee: nobody → bzbarsky
Priority: -- → P1
Whiteboard: [good first bug] → [need gk2 ship]
Thanks for review!
Assignee: bzbarsky → borisov.gleb
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [need gk2 ship]
Target Milestone: --- → mozilla2.2
Thanks for checkin, Boris.
You need to log in before you can comment on or make changes to this bug.