259861 - Should log errors on bindings with no id attribute

Status: RESOLVED FIXED

(Core :: XBL, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 255715 comment 8 and following.

Comment 1

[Ben Fowler]

The stated dependencies of this bug are status FIXED what needs doing here
next?

Create a LogError( "errTag" ) function?

What about Bug 228205? 

Comment 2

[Boris Zbarsky [:bzbarsky]]

What needs to happen is adding an appropriate call to
nsContentUtils::ReportToConsole when this error is encountered (along with a
string addition to content/xbl/src/xbl.properties).

Bug 228205 isn't as relevant here because nsContentUtils is abstracting away a
good bit of the api.

Comment 3

[Gleb M. Borisov]

Attachment: Error message added

I know that this bug is old enough, but it's really annoying.
I have changed ConstructBinding method signature to accept line number to show it in error message.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 512210 [details] [diff] [review]
Error message added

r=me.  Thank you for doing that!

Unfortunately, the tree is locked down for the Gecko 2.0 release right now; I'll make sure to get this checked in as soon as it reopens.  It'll be a few weeks.  :(

Comment 5

[Gleb M. Borisov]

Thanks for review!

Comment 6

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/21e30c46c08d

Comment 7

[Gleb M. Borisov]

Thanks for checkin, Boris.