260041 - "Find as you Type" link in frame without focus no longer gets input focus

Status: VERIFIED WORKSFORME

(Toolkit :: Find Toolbar, defect)

Description

[Scott Fohey]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10

"Find as you Type" link in frame without focus no longer gets input focus:

On the example web site upon loading if I "Find as you Type" 'tutorial',
the link is found, and gets highlighted, but the frame doesn't seem to get
input focus.  The consequence of this is that if I (*Windows Specific*) type
<shift><F10> to get the right-click context menu for the link so that I can
"Open Link in New Tab", I don't get it.  I get the context menu for whatever
object has input focus.

This seems to be a behavior change between 0.9.3 and 1.0PR.  0.9.3 worked fine
in this respect.


Reproducible: Always
Steps to Reproduce:
1. load example page (Or any page with a frameset)
2. 'Find as you Type' for tutorial
3. type <shift> <F10>

Actual Results:  
the context menu for the page is displayed

Expected Results:  
the context menu for the link 'tutorial' should have been displayed

Happens with Default Theme, on XP. It happens with pinball theme on 2k

Comment 1

[q]

(In reply to comment #0)
> User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3)
Gecko/20040913 Firefox/0.10
> Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3)
Gecko/20040913 Firefox/0.10
> 
> "Find as you Type" link in frame without focus no longer gets input focus:
> 
> On the example web site upon loading if I "Find as you Type" 'tutorial',
> the link is found, and gets highlighted, but the frame doesn't seem to get
> input focus.  The consequence of this is that if I (*Windows Specific*) type
> <shift><F10> to get the right-click context menu for the link so that I can
> "Open Link in New Tab", I don't get it.  I get the context menu for whatever
> object has input focus.
> 
> This seems to be a behavior change between 0.9.3 and 1.0PR.  0.9.3 worked fine
> in this respect.
> 
> 
> Reproducible: Always
> Steps to Reproduce:
> 1. load example page (Or any page with a frameset)
> 2. 'Find as you Type' for tutorial
> 3. type <shift> <F10>
> 
> Actual Results:  
> the context menu for the page is displayed
> 
> Expected Results:  
> the context menu for the link 'tutorial' should have been displayed
> 
> Happens with Default Theme, on XP. It happens with pinball theme on 2k

I can confirm this.   Upon using find as you type on a page with frames and then
hitting escape to continue browsing, the frame that contains your search term
does not get focus.  The focus does not even return to the frame that previously
had focus.  This is only a problem for me because it hinders browsing with the
keyboard.

Comment 2

[Ger Teunis]

I confirm this bug, pressing enter (follow the link) doesn't work either
Test on menu of http://www.demon.nl/producten/internettoegang/dslexpress/

Comment 3

[Hari Krishna Dara]

This breaks the most helpful feature for keyboard users. You can no longer press
Enter after finding the link using "find as you type" feature.

Comment 4

[Dave]

I confirm this bug. For instance, in 

http://java.sun.com/j2se/1.5.0/docs/api/index.html

If I type, for instance, AbstractAction, which is a link contained in an
out-of-focus frame on that page, Firefox correctly finds the link, but I cannot
hit enter to bring up that link in the big frame. I was able to do this with
Firefox version <= 9.

Comment 5

[Phil Ringnalda (:philor)]

*** Bug 266497 has been marked as a duplicate of this bug. ***

Comment 6

[pedro]

This also appens in linux, for versions > 0.9.

It is really annoying if you want to use firefox as an api reader. This was one
of the greatest features in firefox. 

Comment 7

[Phil Ringnalda (:philor)]

*** Bug 270396 has been marked as a duplicate of this bug. ***

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Regression seems to appear somewhere between 0.9 and 1.0PR.

Comment 9

[Matthias Hillebrand]

problem also occurs on www.telefon-treff.de.

Comment 10

[Matthias Hillebrand]

sry for double post: 

Problem also occurs on www.telefon-treff.de.

Tested on Firefox 1.0 german, Windows XP pro.

Comment 11

[James Nord]

Dupe of 254722

*** This bug has been marked as a duplicate of 254722 ***

Comment 12

[Jesse Ruderman]

*** Bug 284736 has been marked as a duplicate of this bug. ***

Comment 13

[Jesse Ruderman]

Since bug 254722 is a mess and this bug is not, I think this shouldn't be marked
as a dup of bug 254722.

Comment 14

[Peter Liljenberg]

This fails in 1.0.2 too.  The problem seems to be that typeahead doesn't move
focus among frames.  Here is a sure-fire way of reproducing it:

1. Go to http://www.catb.org/~esr/jargon/html/frames.html
2. Click in lower-left frame
3. Type "tbs" and hit return, should load 1TBS page in right frame
4. Type "n", highlightning and focusing the link "404-compliant" (do not hit return)
5. type "ext", which highlights the "Next" link in the right frame but focus
stays in lower-left frame on "404-compliant".
6. Hit return, which loads "404-compliant" in the right frame.

Comment 15

[Peter Liljenberg]

One more thing: I tested this on Linux, so it seems to be platform-independent.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I can confirm it with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6)
Gecko/20050325 Firefox/1.0.2 (Debian package 1.0.2-1)

OS => ALL

Comment 17

[:Gavin Sharp [email: [e-mail]]]

*** Bug 298363 has been marked as a duplicate of this bug. ***

Comment 18

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Currently, the focus is always set to the editor of find toolbar if FAYT mode.
Therefore, if you click Shift + F10, you can open editor's context menu.
And the problem that the found link doesn't have (pseudo-)focus is fixed by bug
300105.

If you hope that the context menu should be opened on found link, please file a
new bug(enhancement) and add to cc me.

-> WFM.

Comment 19

[Ricardo Mak]

(In reply to comment #18)
> Currently, the focus is always set to the editor of find toolbar if FAYT mode.
> Therefore, if you click Shift + F10, you can open editor's context menu.
> And the problem that the found link doesn't have (pseudo-)focus is fixed by bug
> 300105.
> 
> If you hope that the context menu should be opened on found link, please file a
> new bug(enhancement) and add to cc me.
> 
> -> WFM.

Confirm fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4)
Gecko/20050906

Thanks for solving this bug, now navigating in Java API page is like flying!

Comment 20

[pedro]

I still have this problem (1.0.6, windows).

goto: http://java.sun.com/j2se/1.5.0/docs/api/ , type string, press enter.
Nothing happens.

Comment 21

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Please don't add comment for 1.0.x.
Because we never fix non-security issues on 1.0.x.
Please test with trunk builds.

Comment 22

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

See bug writing guidlines.
http://www.mozilla.org/quality/bug-writing-guidelines.html

> Next, be sure that you've reproduced your bug using a build released within
the past three days. Our development process moves at lightning speed, and the
bug you've found may already have been fixed. (Nightly builds can be downloaded
from the mozilla.org binaries page.)

Comment 23

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Fine for my Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4)
Gecko/20050908 Firefox/1.4

Marking v. and setting target milestone to 1.5 to see in which timeframe this
bug was fixed by another patch.

Comment 24

[Phil Ringnalda (:philor)]

*** Bug 306181 has been marked as a duplicate of this bug. ***