Closed Bug 260335 Opened 20 years ago Closed 20 years ago

"Colors" are not lockable in Preferences->Appearance->Colors page (color/colour picker)

Categories

(SeaMonkey :: Preferences, defect)

Product:
SeaMonkey
Component:
Preferences
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: eagle.lu, Assigned: neil)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files, 1 obsolete file)

Proposed patch
11.47 KB, patch
janv
: review+
jag+mozilla
: superreview+
Details | Diff | Splinter Review
toolkit port: support disabling colorpicker buttons (checked in)
2.93 KB, patch
mconnor
: review+
Details | Diff | Splinter Review 
All color picker items on this page is not lockable.
Attached patch patch v0 (obsolete) — — Splinter Review 

    
    

    
  
Comment on attachment 159388 [details] [diff] [review]
patch v0

Can you give r? thanks

        Attachment #159388 -
        Flags: review?(neil.parkwaycc.co.uk)
Summary: "Colors" are not lockabe in Perferences->Apparance->Colors page → "Colors" are not lockable in Perferences->Appearance->Colors page
Summary: "Colors" are not lockable in Perferences->Appearance->Colors page → "Colors" are not lockable in Preferences->Appearance->Colors page

    
    

    
  
Comment on attachment 159388 [details] [diff] [review]
patch v0

As an alternative I'm looking into getting rid of these colorpicker hacks.

        Attachment #159388 -
        Flags: review?(neil.parkwaycc.co.uk) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Proposed patch
        — 
          — Splinter Review
      

    


  
This improves on the disabled support for colorpicker and teaches the wsm about
the colorpicker so that it saves the state and locks it correctly.

    
  
Assignee: prefs → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED

    
  

        Attachment #159592 -
        Flags: review+

    
  

        Attachment #159592 -
        Flags: superreview?(jag)

    
    

    
  
Comment on attachment 159592 [details] [diff] [review]
Proposed patch

Index: components/prefwindow/resources/content/nsPrefWindow.js

It seems like the "elt -> prefattribute" and "elt -> preftype" switches should
be factored out into helper functions.

What happened to indentation there?
+      <property name="disabled" onset="if (val)
this.setAttribute('disabled',true);
+					  else
this.removeAttribute('disabled');
+					  return val;"
+				   onget="return
this.hasAttribute('disabled');"/>
+

I'm assuming you'll remove the pref-colors.js file when you check in.

sr=jag if you at least fix those indent nits, karma points for factoring the
duplicate code out into functions.

        Attachment #159592 -
        Flags: superreview?(jag) → superreview+

    
    

    
  
Indents fixed and checked in, pref-colors.js removed.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Summary: "Colors" are not lockable in Preferences->Appearance->Colors page → "Colors" are not lockable in Preferences->Appearance->Colors page (color/colour picker)

    
    

    
  
*** Bug 84212 has been marked as a duplicate of this bug. ***
Blocks: 70538, 113387
OS: Linux → All
Hardware: PC → All

    
  

        Attachment #159388 -
        Attachment is obsolete: true
Product: Browser → Seamonkey

    
    

    
  
Comment on attachment 167932 [details] [diff] [review]
toolkit port: support disabling colorpicker buttons (checked in)

ok, but please file a followup bug to port the rest if you're not doing this
soon.

        Attachment #167932 -
        Flags: review?(mconnor) → review+

    
    

    
  
Comment on attachment 167932 [details] [diff] [review]
toolkit port: support disabling colorpicker buttons (checked in)

ok. this patch is checked in; porting wsm and prefwindow changes is bug 273287

        Attachment #167932 -
        Attachment description: toolkit port: support disabling colorpicker buttons → toolkit port: support disabling colorpicker buttons (checked in)

    
    

    
  
*** Bug 199789 has been marked as a duplicate of this bug. ***

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: