46 bytes, text/x-phabricator-request
|Details | Review|
Find as you type doesn't work on Macs. The new, cute search bar on the bottem immediately goes away after I typed only one letter and the next letter immidiately starts a new search, no matter how fast I type. I set accessibility.typeaheadfind.enabletimeout to false, so it should stay there forever, but it goes away immediately
Oh, my current browser version, of course: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3) Gecko/20040919 Firefox/0.10
Works for me in build 20040920 (branch) Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3) Gecko/20040920 Firefox/0.10
Jo, can you do me a favor? Can you open a new tab and enter "about:config" as address. Then please enter "typea" into the filter line. Some lines will be left over. Can you please post all the settings left over here? I'd like to compare them to my settings. Maybe this explains why it works for you but not for me. Maybe it's a setting problem. But then it's still a bug IMHO. No setting should cause such an incorrect behavior.
Okay, I made some tests myself. The problem is, that accessibility.typeaheadfind.enabletimeout is ignored on the Mac (or it is ignored in general. Have to test it under Windows this evening). The setting accessibility.typeaheadfind.timeout was set to 0 in my config; this was the way how to disable timout in earlier versions. But now 0 really means a timeout of 0, so it times out at once. May I suggest a solution for this problem? A timeout of 0 should still be treated as "no-timeout", since it makes no sense to really have a timeout of 0. And accessibility.typeaheadfind.enabletimeout should be honored when set to false, regardless of timeout set.
Summary: Find as you type doesn't work any longer on Macintosh → accessibility.typeaheadfind.enabletimeout is ignored
Confirmed in Windows (XP + SP2) Assuming it applies to all platforms
OS: MacOS X → All
this bug is fixed with the patch in bug 265915
We can close it once the patch has been checked in and I can verify correct behavior in one of the nightly builds
Depends on: 265915
Confirmed. Running Windows XP Pro SP2, tested with Firefox 1.0.1 and latest Trunk with clean profiles.
Same thing here (Mozilla/5.0 (Windows; U; Windows NT 5.1; fr-FR; rv:1.7.6) Gecko/20050223 Firefox/1.0.1) Find as you type dialog box just appears a microsecond. accessibility.typeaheadfind.timeout=5000 accessibility.typeaheadfind.enabletimeout=true Note the Ctrl-F shortcut or menu action just works find : dialog box stay active indefinitely
This is still broken in Firefox 1.5 RC3. The find bar disappears after 5 seconds even when accessibility.typeaheadfind.enabletimeout is false. I'm running Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5 on Windows XP SP2. I did a clean install of Firefox 1.5 RC3, not an upgrade, no old preferences or settings. Extensions I'm using: DOM Inspector, Talkback, Google Toolbar for Firefox Workaround: Set accessibility.typeaheadfind.timeout to 999999999 and restart Firefox.
Assignee: firefox → nobody
QA Contact: fast.find
Hardware: Macintosh → All
Version: unspecified → Trunk
20/9/2004: please fix this bug! Thank you!
Mike DeBoer correctly noted in a comment at https://bugzilla.mozilla.org/show_bug.cgi?id=254592 that enabletimeout is no longer used and should be removed. I updated the timeout logic to treat a zero or negative value as effectively "no automatic timeout" for the quick-find dialog (otherwise, setting the timeout value to a small or negative value makes the feature unusable). This is a corollary to the bugfix at https://phabricator.services.mozilla.com/D3404 ; I've split it out into a separate patch to avoid confusing that issue. Update: this specific issue already had its own bug at https://bugzilla.mozilla.org/show_bug.cgi?id=260562, and another mention at https://bugzilla.mozilla.org/show_bug.cgi?id=265915 .
Comment on attachment 9001904 [details] Remove obsolete accessibility.typeaheadfind.enabletimeout preference. Kris Maglione [:kmag] has approved the revision.
Attachment #9001904 - Flags: review+
With Diff 8711 on Sat, August 18, 2018, 1:25 AM GMT+3, by firstname.lastname@example.org. Error: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmpmwiPga\npatching file toolkit/content/widgets/findbar.xml\nHunk #1 succeeded at 335 with fuzz 2 (offset -3 lines).\nHunk #2 FAILED at 373\n1 out of 3 hunks FAILED -- saving rejects to file toolkit/content/widgets/findbar.xml.rej\nabort: patch failed to apply', '')
(In reply to Cosmin Sabou [:CosminS] from comment #15) Rebased, should succeed now.
(In reply to spillner from comment #16) > (In reply to Cosmin Sabou [:CosminS] from comment #15) > > Rebased, should succeed now. In the future, please add the checkin-needed keyword when something is ready to land :)
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f4f56776a112 Remove obsolete accessibility.typeaheadfind.enabletimeout preference. r=kmag
You need to log in before you can comment on or make changes to this bug.