260874 - Help window Activity Indicator (throbber) isn't right

Status: RESOLVED FIXED

(SeaMonkey :: Help Viewer, defect)

Description

[caio chassot]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3) Gecko/20040913 Firefox/0.10

Pinstripe Help window Activity Indicator (throbber) uses the Winstripe image
instead of the mac image (as in the browser window)

Reproducible: Always
Steps to Reproduce:
1. Load help

Actual Results:  
Winstripe Throbber

Expected Results:  
Pinstripe throbber

Comment 1

[caio chassot]

Attachment: screenshot

Comment 2

[caio chassot]

it's also a tad bit misaligned

Comment 3

[Jeff Walden (gone starting June 8)]

Yes, I noticed this recently while working on another bug.  The throbber,
incidentally, isn't even right for Winstripe -- it's just a Qute holdover that
looks so similar to the Winstripe equivalent that it's been ignored.

I'll get this sometime soon, certainly before 1.0.

Comment 4

[R.J. Keller]

heh, that's a pretty good catch! I'll cook something up real quick.

Comment 5

[R.J. Keller]

Attachment: Patch - uses Firefox throbber

Comment 6

[Jeff Walden (gone starting June 8)]

Comment on attachment 160206 [details] [diff] [review]
Patch - uses Firefox throbber

The URLs you use are wrong.  For the inactive throbber you want:

url("chrome://browser/skin/Throbber-small.png");

For the active throbber you want:

url("chrome://browser/skin/Throbber-small.gif");

Also, can you transfer any other CSS over from the location below that we
haven't duplicated in Help CSS?  I notice -moz-opacity: 0.5; in the busy
indicator CSS, at the very least, but I'm running short on time to look to see
if anything else is missing.

http://lxr.mozilla.org/aviarybranch/source/browser/themes/winstripe/browser/bro
wser.css#773

One final note, because someone will point it out if I don't mention it now:
this introduces a toolkit dependency on browser.  For the aviary branch it
doesn't matter -- only Firefox will use Help.  For trunk, it's another issue,
and I'll probably fix it with bug 260058 (somewhat like I described somewhere
in the notes I made as a comment).

Comment 7

[Jeff Walden (gone starting June 8)]

Gaah!  Invalid assumption!

Pinstripe doesn't use the same images as Winstripe for the location of the
throbber images.  Check out this bit of code for the proper locations:

http://lxr.mozilla.org/aviarybranch/source/browser/themes/pinstripe/browser/browser.css#785

Comment 8

[R.J. Keller]

eek, OK back to you jeff :).

Comment 9

[Jeff Walden (gone starting June 8)]

(In reply to comment #8)
> eek, OK back to you jeff :).

It's not that difficult a fix -- it just requires five minutes or so of
research.  Are you sure you can't get to this?  Please?

Comment 10

[Asaf Romano (gone)]

*** This bug has been marked as a duplicate of 242801 ***

Comment 11

[Jeff Walden (gone starting June 8)]

No, this isn't a duplicate.

For starters, I understand exactly what the specific problem is here, and it's
not specific to Help on Macs -- Windows also uses the wrong throbber.  Bug
242801 now relates to the screwy scroll bars in the window on Macs (as far as I
can tell from screen shots, that is), and just because it deals with Pinstripe
in Help on the Mac doesn't mean this bug's a duplicate of it.

Anyways, resummarizing so ithe problem's better described...

Comment 12

[Jeff Walden (gone starting June 8)]

Attachment: Update throbber CSS to mirror that of main browser throbber

This updates the CSS to be the same as that which the main browser uses in
Pinstripe/Winstripe.

Comment 13

[Jeff Walden (gone starting June 8)]

Comment on attachment 160271 [details] [diff] [review]
Update throbber CSS to mirror that of main browser throbber

Steffen, this look good?

Remember: *only for aviary* because it introduces a toolkit dependency on
browser!

Comment 14

[Steffen Wilberg]

I've got a better idea. We're already packing throbber.png and throbber-busy.gif
into help.jar. This is done from mozilla/toolkit/themes/[w|p]instripe/help/jar.mn.

All we need to do is to update these files: Copy the respective winstripe
(browser/themes/winstripe/browser/Throbber-small.*) and pinstripe
(mozilla/toolkit/themes/pinstripe/global/icons/loading_16.gif and
notloading_16.png) throbber files to toolkit/themes/winstripe/help and
toolkit/themes/pinstripe/help. If we keep the file names in the latter
directories (throbber*), we don't have to change any jar.mn or help.css file.

Comment 15

[Jeff Walden (gone starting June 8)]

(In reply to comment #14)
> If we keep the file names in the latter directories (throbber*), we don't have
> to change any jar.mn or help.css file.

...except that other CSS besides the URL needs to be updated, so we might as
well just use the patch.  Besides, then we have to track down someone to check
in copies of the images (although I don't see a reason we can't check them in
ourselves).  There's a UI freeze on October 1, and there's a small chance this
would fall under that heading.  I *really* don't want to find out for certain
whether it would or not.

Comment 16

[Steffen Wilberg]

Comment on attachment 160271 [details] [diff] [review]
Update throbber CSS to mirror that of main browser throbber

UI freeze? That'll be a (hard) l10n freeze IIRC. 

But OK.

Comment 17

[Asa Dotzler [:asa]]

Comment on attachment 160271 [details] [diff] [review]
Update throbber CSS to mirror that of main browser throbber

a=asa for aviary checkin.

Comment 18

[Jeff Walden (gone starting June 8)]

Fixed on branch only.  Leaving open for a better toolkit-aware trunk fix that'll
likely be part of bug 260058...

Comment 19

[Steffen Wilberg]

Fixed on trunk by the branch landing. Bug 268776 or bug 260058 will take care of
the evil browser dependencies.