260879 - download controls should be buttons, not links

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[caio chassot]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10

The cancel, pause, open & remove controls for each download should be buttons,
not links. Links are web page controls and have no place in the application
unless they load a URL.

Reproducible: Always
Steps to Reproduce:
1. Start a download
2. Look at the controls

Actual Results:  
controls are links

Expected Results:  
controls are buttons

Comment 1

[Prognathous]

Confirming bug based on Windows UI guidelines:

"In Web-style applications, you can include both hyperlinks and command buttons
in your interface. As a general rule, use hyperlinks for navigating to locations
and buttons for carrying out actions."

Design Specifications and Guidelines -> Window Management -> Web-Application
Interface
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dnwue/html/ch10e.asp

Firefox is *not* a web application, it's an application that runs locally.
Therefore, it should use standard application widgets (i.e. buttons in this case).

Prog.

Comment 2

[Peter van der Woude [:Peter6]]

*** Bug 285852 has been marked as a duplicate of this bug. ***

Comment 3

[Jesse Ruderman]

*** Bug 340334 has been marked as a duplicate of this bug. ***

Comment 4

[Shawn Wilsher :sdwilsh]

I *really* don't think a litmus test is needed for this.

Comment 5

[Shawn Wilsher :sdwilsh]

Fixed by Bug 388517.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Yeah, this is fine on Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007081304 Minefield/3.0a8pre and Linux/Windows XP SP2/Vista OSs; I'll be spinning off any/all separate bugs for specific cases (tooltips/functions/appearance, etc.).

Verified FIXED