Firefox self extracting archive is not fully localizable through l10n CVS - Allow localization of 7zSD.sfx

NEW
Unassigned

Status

()

defect
P3
trivial
15 years ago
2 years ago

People

(Reporter: p.franc, Unassigned)

Tracking

(Blocks 1 bug, {l12y})

unspecified
x86
Windows 2000
Points:
---
Dependency tree / graph
Bug Flags:
blocking-aviary1.0 -

Firefox Tracking Flags

(Not tracked)

Details

()

Reporter

Description

15 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; cs-CZ; rv:1.7) Gecko/20040803 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; cs-CZ; rv:1.7) Gecko/20040803 Firefox/0.9.3

This file contains a code that is run in the beggining of instalation proces
when the Extracting dialog appears. This can be easily localize by Resource
Hacker to show l10n string insted.

Reproducible: Always
Steps to Reproduce:

Comment 1

15 years ago
*** Bug 262282 has been marked as a duplicate of this bug. ***

Comment 2

15 years ago
Confirming based on dupe, transferring dependencies from duped bug. Requesting
blocking.
Blocks: 259167, 259227
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-aviary1.0?
Keywords: l12y
Summary: Allow localization of 7zSD.sfx → Firefox Installer is not fully localizable through l10n CVS - Allow localization of 7zSD.sfx

Comment 3

15 years ago
This is a very minor bug, and does not block 1.0.  Neither Ben nor I has the
time to do the (rather extensive) hacking necessary to automate some form of
resource-substitution on the 7zSD.sfx file, nor do I particularly want to have a
build dependency on a resource editor utility. If a low-risk patch were to
magically appear, I might consider it.
Severity: normal → trivial
Flags: blocking-aviary1.0? → blocking-aviary1.0-
QA Contact: bugzilla → bsmedberg

Comment 4

15 years ago
Do not you think that the translated binary 7zSD.sfx can be directly uploaded?
Would you consider this a security risk?
Reporter

Comment 5

15 years ago
> If a low-risk patch were to magically appear, I might consider it.

Could it be based on the following idea

a) in other-licenses/7zstub/firefox/ create a directory for each locale version
b) move english 7zSD.sfx into other-licenses/7zstub/firefox/en-US/7zSD.sfx
c) ll0n teams attach their 7zSD.sfx to this bug (or send by email), and move
this files into the corresponding subdirectory

c) in
http://lxr.mozilla.org/aviarybranch/source/browser/installer/windows/installer.cfg#15

replace the line

7ZipSFXModule             = other-licenses/7zstub/firefox/7zSD.sfx

with the following condition

#ifdef LOCALE_HAS_7ZIPSFXMODULE
7ZipSFXModule             = other-licenses/7zstub/firefox/@AB-CD@/7zSD.sfx
#else
7ZipSFXModule             = other-licenses/7zstub/firefox/en-US/7zSD.sfx
#endif

If this is reasonable request, we need somebody with enough time and rights to
do the above modification in CVS. 

*** Bug 342199 has been marked as a duplicate of this bug. ***
Assignee: bugs → nobody
QA Contact: benjamin → installer
Problem confirmed with Tbird 1.5.0.7 and various 10ln

Also the uninstaller is not translated on 10ln Builds
The possible ways to fix this are as follows with '1' being the most preferred method as I see it:
1) Command line resource editor to replace the strings. If we support Win9x we would also have to set the font for East Asian locales.
2) Compile the 7zSD.sfx. We have the source in the tree now but we would have to install MSVC6 on the Win32 tinderboxes.
3) Create a separate 7zSD.sfx for each locale.
Summary: Firefox Installer is not fully localizable through l10n CVS - Allow localization of 7zSD.sfx → Firefox self extracting archive is not fully localizable through l10n CVS - Allow localization of 7zSD.sfx

Comment 9

13 years ago
Hmm.... If Firefox3 will be distributed as a .msi for windows users, this would be quite irrelevant, no?
7-Zip supports creating SFX archive. It might be helpful for l10n.

Comment 11

12 years ago
(In reply to comment #10)
> 7-Zip supports creating SFX archive. It might be helpful for l10n.

I see two ways here:
1) have a separate SFX module for each locale, as suggested by comment #8

2) Compile a customized SFX module ourselves ONCE. The long explanation follows:

Actually, the 7-zip module for installers already supports certain customization. According to 7-zip for installers README file:

> Self-extract archive for installers must be created 

> as joining 3 files: SFX_Module, Installer_Config, 7z_Archive. 

> Installer_Config is optional file.

The config file currently may look like this:

;!@Install@!UTF-8!

Title="„Firefox“ įdiegimas"

BeginPrompt="Ar norite įdiegti „Firefox“ Jūsų kompiuteryje?"

RunProgram="setup.exe"

;!@InstallEnd@!


With this config, the user would get a localized question asking if they want to install Firefox.

Now, I think it should be possible to simply compile a custom SFX module once, which would allow more strings to be changed the same way. If we could add just a few customizable strings like the ones above to the same module, the problem would be solved gracefully, IMHO. Each locale could have needed strings in the tree (or even the config file itself), and they wouldn't need to upload any binary files.

Also, I think the "Cancel" button, which is currently not localized, could actually take its name from the operating system, as already do the buttons, that appear when I press that "Cancel" button. Or they all should be customizable. It makes simply no sense to have "Cancel" in one dialog, and "Atšaukti" in the other.

And as a side effect, we could get the uxtheme'd buttons in the installer right from the beginning.

Comment 12

11 years ago
Isn't this fixed? Maybe with the Unicode fixes? Bug 305039 or Bug 399153
No, this is for the 7zSD.sfx which is the 7-Zip self-extracting archive.
Blocks: 1249804
Depends on: 1360927
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.