One of the many bugs fixed in NSS 3.9 was that NSS would previously accept
only UTCTimes and not GeneralizedTimes in many places (in many types of PKI
SEQUENCES, like certs and CRLs). The fix was to replace the UTCTime tag
in most templates with a CHOICE subtemplate that allowed either form of time.
So, in CRLs, the template for the nextUpdate field changed from being an
OPTIONAL UTCTime to being an OPTIONAL CHOICE. The QuickDER decoder used for
CRLs has an original bug (which is not a regression in 3.9), namely that it
mishandles missing optional CHOICEs. Apparently we never had any optional
choice templates until 3.9.
In any case, the combination of the new OPTIONAL CHOICE template and the
original QuickDER bug (treats missing optional choices as errors) cause the
regression that NSS can no longer corrrectly parse CRLs that lack the
optional nextUpdate component.
I have a patch that fixes this, and a related patch that prevents certutil
and PP from crashing on CRLs with missing nextUpdate fields.
I would like this fix to go into NSS 3.9.3 and into NSS 3.10.
Thanks to Bill Burns who discovered that CRLs without nextUpdate fields
cannot be printed by pp.
Targetting 3.9.3. I believe Julien agrees with this.
Created attachment 160026 [details] [diff] [review]
patch v1 for trunk
Comment on attachment 160026 [details] [diff] [review]
patch v1 for trunk
Julien, please review
Created attachment 160027 [details] [diff] [review]
patch v1 for NSS_3_9_BRANCH
The only difference between these two patches are the line numbers
in the diffs. So, I won't ask for this patch to be reviewed separately.
Good catch, Nelson. I wish our test suite had some CRL coverage. We really have
to get on it.
Fix checked in on NSS 3.9 branch.
Checking in lib/util/quickder.c; new: 18.104.22.168; previous: 1.19
Checking in cmd/lib/secutil.c; new: 22.214.171.124; previous: 126.96.36.199
Checked in on trunk
Checking in lib/util/quickder.c; new revision: 1.21; previous revision: 1.20
Checking in cmd/lib/secutil.c; new revision: 1.66; previous revision: 1.65
nominating for firefox 1.0
NSS 3.9.3 is on aviary/1.7
*** Bug 231907 has been marked as a duplicate of this bug. ***