261679 - Provide anti-aliased PNG icons for Gnome and KDE

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Henri Sivonen (:hsivonen)]

SuSE provides a non-anti-aliased icon for Firefox that looks bad compared to
other KDE icons. I've seen the same problem on Debian/Gnome. Copying the OS X
icon (as PNG) over remedies the problem.

It would be nice if the branding materials for Linux included the same icon that
is used on OS X, so that it would be easy for distros to roll out packages whose
icons don't look out of place in KDE and Gnome.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Anti-aliased, pngcrushed, 128 by 128 Firefox app icon

Attaching a PNG version of the OS X icon.

Comment 2

[Mike Connor [:mconnor]]

Steven, Bart, this would be a good thing, the xpm gets real ugly-like on a
largish GNOME toolbar, which I happen to use... 

Comment 3

[Steven Garrity [:sgarrity]]

By all means. The attached PNG is exactly what we need. I've wanted this for a
while, but haven't known how to get it in.

The Fedora package has been putting the icon in themselves (with permission) -
but it would be nice to fix this upstream for them.

We probably just want to use the 128px version posted (same as OS X), but for
those interested, jimmac did a version with the stock Gnome visual style:
http://primates.ximian.com/~jimmac/blog/Artwork/Firefox.html

Comment 4

[Henri Sivonen (:hsivonen)]

Should I file a separate bug about Thunderbird?

Comment 5

[Steven Garrity [:sgarrity]]

Yes, please file a bug for Thunderbird.

Comment 6

[Henri Sivonen (:hsivonen)]

Filed bug 262265 about Thunderbird.

Comment 7

[Steven Garrity [:sgarrity]]

Attachment: Updated to proper 1.0 version of Firefox icon

Here's the more recent version of the icon (128px by 128px, full-color
transparent PNG) that shipped in the 1.0 version on Windows and Mac OS X.

Comment 8

[nulldomain]

Can I at least understand why is can't go into 1.1?  I'll help anyway I can to
get this in there.

Comment 9

[Steven Garrity [:sgarrity]]

Joseph: "blocking-aviary1.1 -" doesn't necessarily mean it won't or can't be in
1.1. Rather, it just means that 1.1 won't be blocked if it's not done (right?).

Comment 10

[Mike Connor [:mconnor]]

Exactly.  Basically this needs some build-fu loving to be packaged into the
release GTK builds, so if there's a patch, great, but if people really want they
can get the icon here.

Comment 11

[Mike Connor [:mconnor]]

Steven, can we get an equivalent for non-officially branded builds too?

Comment 12

[Steven Garrity [:sgarrity]]

Attachment: Generic (non-branded) Firefox icon

Here's the non-branded version Mike. Same type of image: 128 by 128 pixels,
full color, transparent PNG.

Comment 13

[Marek Stępień [:marcoos, inactive]]

Attachment: Patch (adds the files to respective Makefile.in's)

This patch assumes that the branded Firefox PNG icon (attachment 176484 [details]) is at:


other-licenses/branding/firefox/mozicon128.png

and the non-branded one (attachment 178790 [details]) at:

browser/app/mozicon128.png

So the image files must be also cvs added.

Comment 14

[Marek Stępień [:marcoos, inactive]]

mconnor: Does this also need approval-1.1a2 or can this be checked in?

Comment 15

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 186594 [details] [diff] [review]
Patch (adds the files to respective Makefile.in's)

Yes, it needs approval, everything does.

Comment 16

[Marek Stępień [:marcoos, inactive]]

Can someone check in the patch and cvs add the images? I only have l10n cvs
access...

Comment 17

[Zibi Braniecki [:zbraniecki][:gandalf]]

Checking in browser/app/Makefile.in;
/cvsroot/mozilla/browser/app/Makefile.in,v  <--  Makefile.in
new revision: 1.83; previous revision: 1.82
done
RCS file: /cvsroot/mozilla/browser/app/mozicon128.png,v
done
Checking in browser/app/mozicon128.png;
/cvsroot/mozilla/browser/app/mozicon128.png,v  <--  mozicon128.png
initial revision: 1.1
done
Checking in other-licenses/branding/firefox/Makefile.in;
/cvsroot/mozilla/other-licenses/branding/firefox/Makefile.in,v  <--  Makefile.in
new revision: 1.16; previous revision: 1.15
done
RCS file: /cvsroot/mozilla/other-licenses/branding/firefox/mozicon128.png,v
done
Checking in other-licenses/branding/firefox/mozicon128.png;
/cvsroot/mozilla/other-licenses/branding/firefox/mozicon128.png,v  <-- 
mozicon128.png
initial revision: 1.1
done

checked in

Comment 18

[Zibi Braniecki [:zbraniecki][:gandalf]]

resolving as fixed