Closed Bug 262265 Opened 16 years ago Closed 11 years ago

Provide anti-aliased PNG icons for Gnome and KDE

Categories

(Thunderbird :: General, defect, trivial)

All
Linux
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: hsivonen, Assigned: zbraniecki)

Details

Attachments

(2 files)

This is the Thunderbind version of bug 261679. 

The icon provided for Linux looks bad compared to KDE or Gnome icons due to the
lack of anti-aliasing. Copying the OS X icon (as PNG) over remedies the problem.

It would be nice if the branding materials for Linux included the same icon that
is used on OS X (or anti-aliased icons tuned specifically for Gnome and KDE), so
that it would be easy for distros to roll out packages whose icons don't look
out of place in KDE and Gnome.
Attaching a PNG version of the OS X icon.
Steven, could you also provide the 128x128 icon for the generic (non-branded)
Thunderbird?
Assignee: mscott → gandalf
Attached patch patchSplinter Review
patch for both icon sets
Attachment #186677 - Flags: superreview?(mscott)
Attachment #186677 - Flags: review?(mscott)
Attachment #186677 - Flags: approval-aviary1.1a2?
Attachment #186677 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Comment on attachment 186677 [details] [diff] [review]
patch

This now has Asa's approval for 1.1a2, but should not be checked-in until we
have mozicon128.png for the non-branded builds.
sure. I'm also waiting for r+sr from mscott.
Status: NEW → ASSIGNED
Re: Comment #2 from Marek A. Stepien:

I'm not sure a larger version of the generic (non-branded) Thunderbird icon
exists. It was around before I came along. Does anyone know where we could find
a larger original copy?

The only 128px icon I know of is the goofy old Mac OS X one:
http://actsofvolition.com/images/screenshots/thunderbird.png
(In reply to comment #6)
> I'm not sure a larger version of the generic (non-branded) Thunderbird icon
> exists. It was around before I came along. Does anyone know where we could find
> a larger original copy?

The current 50px and 16px versions of mozicon.xpm (mail/app/mozicon*.xpm in CVS)
use the Qute envelope icon with the old Thunderbird logo (that blue leaves
orwhatever that is ;))

Or - maybe just like Firefox: unofficial logo is the globe without the fox, so
maybe we should remove the Bird from the official Tb logo and just leave the
envelope? I suppose John Hicks could help here.

Either way, mozicon*.xpm should be consistent with mozicon128.png.
Maybe that Asa knows where to look for this icon
Attachment #186677 - Flags: superreview?(mscott)
Attachment #186677 - Flags: superreview+
Attachment #186677 - Flags: review?(mscott)
Attachment #186677 - Flags: review+
Attachment #186677 - Flags: approval-aviary1.1a2+
Checking in mail/app/Makefile.in;
/cvsroot/mozilla/mail/app/Makefile.in,v  <--  Makefile.in
new revision: 1.49; previous revision: 1.48
done
Checking in other-licenses/branding/thunderbird/Makefile.in;
/cvsroot/mozilla/other-licenses/branding/thunderbird/Makefile.in,v  <--  Makefile.in
new revision: 1.8; previous revision: 1.7
done
Checking in other-licenses/branding/thunderbird/mozicon128.png;
/cvsroot/mozilla/other-licenses/branding/thunderbird/mozicon128.png,v  <--  mozicon128.png
initial revision: 1.1
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Please check http://tinderbox.mozilla.org/showbuilds.cgi?tree=Sunbird

Seems that your checkin broke the Lightning builds:

gmake[6]: Leaving directory `/builds/tinderbox/Lt-Trunk/Linux_2.4.21-32.0.1.ELsmp_Depend/mozilla/lightning-obj/mail/app/profile'
/builds/tinderbox/Lt-Trunk/Linux_2.4.21-32.0.1.ELsmp_Depend/mozilla/lightning-obj/config/nsinstall -D ../../dist/branding
cp /builds/tinderbox/Lt-Trunk/Linux_2.4.21-32.0.1.ELsmp_Depend/mozilla/mail/app/mozicon128.png ../../dist/branding/mozicon128.png
cp: cannot stat `/builds/tinderbox/Lt-Trunk/Linux_2.4.21-32.0.1.ELsmp_Depend/mozilla/mail/app/mozicon128.png': No such file or directory
damn. Backed out. I'm going to hunt for that non-branded icon :(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
QA Contact: general
Any news on this?
Work for current linux icons is being done in bug 415415
Status: REOPENED → RESOLVED
Closed: 15 years ago11 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.