Closed Bug 261985 Opened 20 years ago Closed 19 years ago

ALT-B, then any letter should scroll through bookmarks starting with that letter

Categories

(Firefox :: Menus, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: eux2s, Assigned: BoxerBoi76)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file, 2 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10

Using keyboard shortcuts, pressing alt-b then "B" or "M" does not currently work
because "B" automatically opens the "Add Bookmark" dialog, and "M" open "Manage
Bookmarks".  Note, it should only scroll if there are other bookmark options
available with that letter, otherwise it's perfectly accectable to have the Add
Bookmarks dialog open when alt-b then b is pressed.



Reproducible: Always
Steps to Reproduce:
1.Add a few book marks and/or folders that start with the letter "b" and "m"
2. Close boomark addition or manangement dialog
3.  Press alt-b then "b"
4.  Pressing the second "b" does not scroll through the "b" bookmarks, but
rather opens the "add bookmark" dialog that is set to have "b" as it's shortcut key.

Actual Results:  
The add bookmark dialog appeared.

Expected Results:  
It should have scrolled through the "b" list on the bookmarks menu of "add
bookmarks" (because short cut key is b for this menu item), then "baking",
"banking online", and "bar tending".

I'm not suggesting that any of the shorcut keys for menu items under the
bookmark menu be changed to something other than what they are now. I am
requesting that the bookmarks menu have the logic to scroll through all options
of any given character, regardless of any predefined, program-driven, menu items.

thanks keep up the great work!
This is probably a problem with the menu widget, not specific to bookmarks. 
I've seen another bug report about this problem but it might have been filed
against Seamonkey.
Assignee: vladimir → aaronleventhal
Component: Bookmarks → Keyboard Navigation
QA Contact: mconnor → jruderman
Blocks: firekey
Keywords: access
Status: UNCONFIRMED → NEW
Component: Keyboard Navigation → XP Toolkit/Widgets: Menus
Ever confirmed: true
Product: Firefox → Core
Version: unspecified → 1.0 Branch
Similar to bug 279135

I suggest a fix where we simply remove the accesskey from "Bookmark this page"
and "Manage Bookmarks", so that B and M still work because they're the first
letter, but also will cycle if there are other things that begin with B and M.
This patch resolves the issue in this bug as well as bug 279135 per Aaron's
suggested fix for both.
Attachment #191811 - Flags: review?(mconnor)
Blocks: 279135
Comment on attachment 191811 [details] [diff] [review]
Resolves issue as requested by Aaron as well as fixes bug: 279135

er, why are you removing the accesskey for Open in Tabs on the contextmenu?
that's totally out of scope for this patch.
Attachment #191811 - Flags: review?(mconnor) → review-
Updated patch to address MConnors "comments"...  "Fix" for bug 279135 removed
from this patch.
Attachment #191856 - Flags: review?(mconnor)
Updated patch to address MConnors "comments"...  "Fix" for bug 279135 removed
from this patch.
Attachment #191811 - Attachment is obsolete: true
Attachment #191857 - Flags: review?(mconnor)
Attachment #191856 - Attachment is obsolete: true
Assignee: aaronleventhal → BoxerBoi76
Component: XP Toolkit/Widgets: Menus → Menus
Flags: review?(mconnor)
Flags: review-
Product: Core → Firefox
QA Contact: jruderman → menus
Version: 1.0 Branch → Trunk
No longer blocks: 279135
Severity: enhancement → minor
Flags: review?(mconnor)
Attachment #191857 - Flags: review?(mconnor)
Attachment #191857 - Flags: review?(mconnor)
Attachment #191857 - Flags: review+
Attachment #191857 - Flags: approval1.8b4+
Checked in by " timeless%mozdev.org ".  Marking fixed!
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Interesting.  IE has similar menu items (_A_dd to Favorites and _O_rganize
Favorites).  If I add a bookmark named "Other", pressing 'O' will properly cycle
between the two menu items.

However, I made a WinForm that has two menu items starting with 'O'.  One had an
explicitly-defined access key (_O_pen) and the other didn't (Other).  Pressing
'O' would execute the Open menu item.

I assume that we want to be like IE in this case.  As such, this would only be a
workaround only and I assume someone's opened a bug to:

1. Fix the underlying problem of preferring explicitly-assigned access keys.
2. Restore the access keys removed by this patch.
Filed bug 306010 to fix the underlying problem.
*** Bug 306560 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.