262727 - manually downloading shockwave player results in a broken download dialog

Status: RESOLVED FIXED

(Toolkit Graveyard :: Plugin Finder Service, defect)

Description

[kstahl]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041002 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041002 Firefox/0.10.1

The plugin system finds Shokwave Player 10, but fails to download it. When you
click the button for a manual download you get a blank and unclosable download
dialog.

Reproducible: Always
Steps to Reproduce:
1. make sure you don't have Shockwave installed.
2. Go to http://www.lovebombing.se/spel/blockout/blockout.html
3. Click the plugin icon and let it search
4. Allow it to install Shockwave 10, accept the licence agreement
5. After it fails to download it, click the Manual button

Actual Results:  
A blank page, with a broken download dialog is presented. The dialog does not
respond to mouse clicks and can not be closed. You have to use the task manager
to close Firefox.

Here is a screenshot:
http://www.e.kth.se/~e97_kjs/temp/plugin-download.png

Expected Results:  
Download Shockwave install file.

Comment 1

[Phil Ringnalda (:philor)]

Ouch. Confirming, after killing and restarting Firefox.

Comment 2

[Doron Rosenberg (IBM)]

jst - what file is pfs hosting for shockwave. Also, maybe I can get access to
the DB/etc so I don't have to bug you all the time :)

Comment 3

[u88484]

firefox doesnt hang, shockwave just fails to install properly

Comment 4

[Phil Ringnalda (:philor)]

(In reply to comment #3)
> firefox doesnt hang, shockwave just fails to install properly

After it fails to automatically install, did you click the manual install
button, which I just noticed appears as only two-thirds of the letter M if you
don't resize the dialog to read the license? That's the hang part: manual
install opens a new blank window, which opens a new modal file download dialog
that has no information supplied to it, and nonfunctional buttons including a
nonfunctional X that doesn't close it.

Doron, I don't think it's so much a matter of "what file?" as "what absence of
file?" - over crappy dialup, the license itself (bloated HTML) takes several
seconds to download, then the install failure takes a fraction of a second,
looking more like nothing at all is downloaded.

Comment 5

[Doron Rosenberg (IBM)]

0.10.1 doesn't have the patch to wait for the license to fully load I think.

Comment 6

[Johnny Stenback (:jst)]

What we currently do for shockwave is to link to the installer on Macromedia's
website as we don't have an agreement that lets us host the installers
ourselves. Macromedia will soon be hosting xpi installers for shockwave (not a
silient one, but at least a xpi one that'll make things a bit easier for our
users). So currently we point to the installer .exe file on the Macromedia
website... not sure why that doesn't work in all cases here, seems to work fine
on my system...

Comment 7

[Phil Ringnalda (:philor)]

Pointing as close as I can to what I suspect, the fix for bug 258535, I
completely nuked my install and profile directories, downloaded
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2004-09-27-08-0.9/FirefoxSetup.exe
and went straight to the URL for this bug, and the manual install button in the
pfs wizard triggered a working file download dialog, that downloaded the
installer. After another nuking and installing
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2004-09-29-09-0.9/FirefoxSetup.exe
the pfs manual install button triggered the described download dialog that looks
like it didn't get passed any arguments about filenames or types, that won't
close without being killed.

Comment 8

[kstahl]

So, is this actually two (related) issues rolled into the same bug?

1. The Shockwave Director 10 (or whatever it's called) fails to load for some
reason.

2. When the file fails to load, the dialog is borked. This would be a problem
for other plugins that failed to load too.

Comment 9

[Phil Ringnalda (:philor)]

(In reply to comment #8)
> So, is this actually two (related) issues rolled into the same bug?

Not exactly, unless you consider the way the installer forces you through the
charade of pretending to install before offering the manual install it knows it
will give you a bug.

As to the critical part, hanging the app by putting up a broken modal download
dialog: I just hacked
http://lxr.mozilla.org/aviarybranch/source/toolkit/mozapps/plugins/content/pluginInstallerWizard.js#482
to call window.opener.open(aUrl) rather than window.open(aUrl) (couldn't think
of a better simple way, I'm not suggesting that as an actual fix), and that
works just fine: a genuine browser window opens, and it opens a working download
dialog.

Comment 10

[Phil Ringnalda (:philor)]

*** Bug 263895 has been marked as a duplicate of this bug. ***

Comment 11

[Doron Rosenberg (IBM)]

Attachment: patch

Comment 12

[Johnny Stenback (:jst)]

Comment on attachment 162098 [details] [diff] [review]
patch

r+sr=jst

Comment 13

[Johnny Stenback (:jst)]

Plusing as blocker as we can not ship with this.

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 162098 [details] [diff] [review]
patch

a=asa for aviary checkin.

Comment 15

[Doron Rosenberg (IBM)]

fixed

Comment 16

[Phil Ringnalda (:philor)]

*** Bug 264655 has been marked as a duplicate of this bug. ***