262789 - Final step of installer says "Click Next to continue" rather than "Click Install to continue"

Status: RESOLVED DUPLICATE of bug 252273

(Firefox :: Installer, defect)

Description

[Vittal Aithal]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20041001 Firefox/0.10.1

Doing either a standard or custom install, the final step shows the phrase
"Click Next to continue.". However, the actual button label is "Install".

Reproducible: Always
Steps to Reproduce:

Comment 1

[Vittal Aithal]

Attachment: Screenshot of the installer dialog

Comment 2

[Bill Mason]

*** This bug has been marked as a duplicate of 252273 ***

Comment 3

[Bill Mason]

Oops, not a dup.  Misread the bug.

Comment 4

[Peter van der Woude [:Peter6]]

l10n impact I assume

Comment 5

[Bill Mason]

*** Bug 263065 has been marked as a duplicate of this bug. ***

Comment 6

[Bill Mason]

*** Bug 268584 has been marked as a duplicate of this bug. ***

Comment 7

[Ernst de Haan]

Indeed this is bug describes the same problem as my bug report (bug #268584) 
does. However, my bug report also mentions that this problem shows up in 2 
screens. See the screen shots attached to bug #268584. 

Comment 8

[Kevin Brosnan]

*** Bug 267671 has been marked as a duplicate of this bug. ***

Comment 9

[Kevin Brosnan]

*** Bug 284498 has been marked as a duplicate of this bug. ***

Comment 10

[Jason Quinn]

One line fix? It appears that this problem can be solved with the change of just one string. I'm a complete hacking notice and I had to learn even how to use CVS to figure this out. Please go easy on me if I'm wrong. I'll have to let somebody else actually create a patch if I'm right because I'm still learning the bugzilla ropes.

/mozilla/mozilla/browser/locales/en-US/installer/installer.inc

contains

#define START_MESSAGE0 Click Next to continue.

which should be changed to 

#define START_MESSAGE0 Click Install to continue.

This string variable is used in
mozilla/mozilla/browser/installer/unix/config.it
mozilla/mozilla/browser/installer/windows/config.it
mozilla/mozilla/browser/installer/windows/install.it

I also looked over
/mozilla/mozilla/toolkit/mozapps/installer/unix/wizard/nsInstallDlg.cpp
/mozilla/mozilla/toolkit/mozapps/installer/unix/wizard/nsXIContext.cpp
/mozilla/mozilla/toolkit/locales/en-US/installer/unix/install.it

because they seem to generate the revelent dialog (the one in the screenshot). It appears that, just changing the START_MESSAGE0 string would resolve this bug and doesn't conflict with anything else. Because of this bug's extremely high visability I think is more than just trivial and should be fixed.

Comment 11

[Robert Strong (they/them - no direct email)]

This was fixed by the checkin of bug 396870 which also fixed bug 252273. Resolving duplicate.