263210 - Switching params while "group by sort" is checked causes crash

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Marcia Knous [:marcia]]

Seen using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3)
Gecko/20041004 Firefox/0.10.1

STR:

1.  Go to View | Sort By | Group by Sort
2.  Check a box other than Date, such as Order Received or Size
3.  Tbird crashes

Filed talkback report TB1157203Z today.

Also once I am in the Group by Sort mode there doesn't seem to be a way to get
out of it, even if I uncheck the pref.

Comment 1

[sairuh (rarely reading bugmail)]

I might be missing something, but the Group by Sort menu item always seems
disabled for me. (using tbird 2004100606-0.8 bits on linux fc2.) I tried having
the focus in various places (thread, message and folder panes), but it remained
disabled --are there certain steps to take before that item is active?

Comment 2

[David :Bienvenu]

this works fine for me...

to get out of group by sort, you can either click on a column header, like date
(which if it didn't crash for you, would get you out of the group view) or you
can do a view | sort by | threaded/unthreaded.

Today's .9 build is very sick because of the dtd issue - the arrow keys, for
example, delete messages. I don't know if that could be involved or not...I
suspect not. 

Do you know why talkback doesn't have the right line numbers? Could you try this
on a windows build?

Comment 3

[David :Bienvenu]

you just have to be sorted by a column we can group by. Those are:

date, subject, sender, recipient, account, label, and priority.

Comment 4

[David :Bienvenu]

oops, grouping by account is incorectly disabled by the ui - I'll attach a patch
to enable the front end part.

And I'll run under Purify to see if I can reproduce the crash.

Comment 5

[sairuh (rarely reading bugmail)]

david, thanks for the info! I usually sort by thread, so that explains why Group
by Sort was disabled for me.

marcia, I cannot seem to crash with this feature (or by other sorting
mechanisms), so far...

Comment 6

[Marcia Knous [:marcia]]

David: I was able to reproduce this crash on today's Windows build as well - I
checked the "Recipient" param. I sent in the Talkback info and will post the
number shortly. I was also able to crash on Mac doing the same thing.

Comment 7

[Marcia Knous [:marcia]]

Windows talkback ID is 1158419

Comment 8

[David :Bienvenu]

Marcia, unfortunately Talkback doesn't have the line numbers/symbols for last
night's build, somehow.

Does this crash happen in all your folders? Does it happen if you're grouped by
another column, e.g., sender? If only date, do you have a message from the
future? (Not sure that would matter, actually)

Comment 9

[Scott MacGregor]

Here's a stack trace I got while grouped by date then clicking the attachment
column to sort by attachment:

    const nsHashKey* hashKey = NS_STATIC_CAST(const nsHashKey*, key);
    return hashKey->HashCode();


haskKey is null

hashKey(PLDHashTable * 0x047b5efc, const void * 0x00000000) line 71 + 3 bytes
PL_DHashTableOperate(PLDHashTable * 0x047b5efc, const void * 0x00000000, int 0)
line 490 + 16 bytes
nsHashtable::Get(nsHashKey * 0x00000000) line 231 + 18 bytes
nsMsgGroupView::GetCellText(nsMsgGroupView * const 0x047b5d10, int 0, const
unsigned short * 0x03914670, nsAString & {...}) line 436 + 19 bytes
nsTreeBodyFrame::PaintText(int 0, nsTreeColumn * 0x045301e0, const nsRect &
{...}, nsIPresContext * 0x02c453d8, nsIRenderingContext & {...}, const nsRect &
{...}, int & 60) line 2814
nsTreeBodyFrame::PaintCell(int 0, nsTreeColumn * 0x045301e0, const nsRect &
{...}, nsIPresContext * 0x02c453d8, nsIRenderingContext & {...}, const nsRect &
{...}, int & 0) line 2580
nsTreeBodyFrame::PaintRow(int 0, const nsRect & {...}, nsIPresContext *
0x02c453d8, nsIRenderingContext & {...}, const nsRect & {...}) line 2422
nsTreeBodyFrame::Paint(nsTreeBodyFrame * const 0x034ca830, nsIPresContext *
0x02c453d8, nsIRenderingContext & {...}, const nsRect & {...}, nsFramePaintLayer
eFramePaintLayer_Overlay, unsigned int 0) line 2207
PresShell::Paint(PresShell * const 0x02c46cac, nsIView * 0x034ce480,
nsIRenderingContext & {...}, const nsRect & {...}) line 5559 + 31 bytes
nsView::Paint(nsView * const 0x034ce480, nsIRenderingContext & {...}, const
nsRect & {...}, unsigned int 0, int & 0) line 264
nsViewManager::RenderDisplayListElement(DisplayListElement2 * 0x0364ad00,
nsIRenderingContext * 0x0376a9c8) line 1429
nsViewManager::RenderViews(nsView * 0x034ce480, nsIRenderingContext & {...},
const nsRegion & {...}, void * 0x0479f838, const nsVoidArray & {...}) line 1347
nsViewManager::Refresh(nsView * 0x034ce480, nsIRenderingContext * 0x0376a9c8,
nsIRegion * 0x03464d90, unsigned int 1) line 906
nsViewManager::DispatchEvent(nsViewManager * const 0x02c46338, nsGUIEvent *
0x0012b620, nsEventStatus * 0x0012b51c) line 1883

Comment 10

[Marcia Knous [:marcia]]

David: Here are the exact steps I followed on my Mac to generate this crash:

1.  Highlight my Inbox folder
2.  Clicked group by sort (date param was already checked)
3.  Clicked another param (recipient)
4.  Then switched to another param (subject)
5.  Tbird crashed.

I am using IMAP and have subfolders set up. I have also seen the Tbird crash
when I was in my bugzilla mail subfolder.

Comment 11

[David :Bienvenu]

Attachment: proposed fix

Comment 12

[David :Bienvenu]

*** Bug 263306 has been marked as a duplicate of this bug. ***

Comment 13

[Marcia Knous [:marcia]]

reopening - i am still getting crashes on both mac and windows on today's build
(20041007). Talkback is backed up, I will put in the stack trace info as soon as
it is available.

This time it appears the crash occured after I switched the param, and then
toggled the widget to expand the messages.

Comment 14

[David :Bienvenu]

Marcia, could you give some steps to reproduce this, including which column you
were grouped by, which column you sorted by, etc? I did fix a crash having to do
with sorting by recipient, but that's not checked in yet.

Comment 15

[sairuh (rarely reading bugmail)]

David, do you have a bug open for the crash on sorting by recepient? (wasn't
able to find one.) after talking to Marcia, that sounds like the one she's
seeing (I'm also able to reproduce it).

Comment 16

[Marcia Knous [:marcia]]

David: I was just able to crash again on the Mac, and it happened when I
switched to the recipient grouped by sort. Sarah had the same thing happen on Linux.

So we basically added the recipient column, sorted by recipient, then selected
view | Sort by group and experienced the crash. I have been able to repro this
consistently on the mac using today's build.

Comment 17

[sairuh (rarely reading bugmail)]

oh it's bug 263385. I'll re-resolve this as fixed, then.

Comment 18

[Ravi]

I had this bug with the version 0.8 (20041009) build today.
I have sent in a talkback report.

1. group by sorting enabled on date column
2. View->Sort By->Flag
And it crashed.

Comment 19

[Erik Arvidsson]

Why is that the column orders change when I select "Grouped by Sort"?

I would prefer if the order was kept and that there was only one primary column.

If the grouping has a group label the label should be in the primary column and
follow the rules for read/unread.

Maybe there are other bugs for these issues?

I can confirm the crash when trying to use grouped by sort on the flag column.