263732 - l10n CVS request - Portuguese, Portugal (pt-PT) - Carlos Rodrigues <[e-mail]>

Status: RESOLVED FIXED

(mozilla.org :: Repository Account Requests, task)

Description

[Carlos Rodrigues]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20041001 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20041001 Firefox/0.10.1

Hi, I would like to request a CVS account for the localization of Firefox (and
Thunderbird, when things are in place for it).

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Carlos Rodrigues]

Attachment: My ssh public key

Comment 2

[Benjamin Smedberg]

1) please attach browser/toolkit ZIPs for review
2) fax and mail the CVS form

Comment 3

[Carlos Rodrigues]

I've already faxed the form (you meant "_or_ mail", right?). I'll attach the
zips in a few days.

Comment 4

[Benjamin Smedberg]

No, you must mail the form. The FAX is a shortcut so that your account can be
activated more quickly.

Comment 5

[Marcia Knous [:marcia]]

fax form received.

Comment 6

[Axel Hecht]

No zips just yet. We would love to see those soon, so that we have a chance to do
a simultanious release in pt-PT, too. Or at least, not be delayed too badly.

Comment 7

[Carlos Rodrigues]

Sorry, time has been short lately. I'll try to pick this up as soon as I can
(though, unfortunately, not in time for simultaneous release with 1.0).

Comment 8

[Carlos Rodrigues]

Attachment: browser localization for pt-PT

Comment 9

[Carlos Rodrigues]

Attachment: toolkit localization for pt-PT

Comment 10

[Carlos Rodrigues]

Ok, the localization zips are attached. A bit late, I know...

However, two remarks:

1. The pt-PT localization for 0.9.3 was good, but this one I couldn't test. Is
there some script to build a langpack, shot of having to build the entire code
for Firefox?

2. I have the help browser translated, but not the help contents itself. I
haven't defined "LOCALE_HAS_HELP" but I added the 3 files (dtd and properties)
that relate to the help browser to the extra-jar.mn file. I don't know if this
works without the whole shebang.

Comment 11

[Carlos Rodrigues]

Attachment: some changes post-zips (browser)

I've been able to make a langpack using the script in the wiki (modified) and I
found some errors, and also found that to be able to have the help browser
translated, I would have to add the whole en-US help.

So, these patches make some corrections to the translation, and add the missing
help files.

Is there any chance this could still be made into an official Firefox pt-PT
release? (after smoketesting the installer and all that).

Comment 12

[Carlos Rodrigues]

Attachment: some changes post-zips (toolkit)

Comment 13

[Carlos Rodrigues]

Attachment: browser localization for pt-PT (2)

I've been reviewing the localization and fixed many minor issues. At this
point, if there are any unsolved issues, they will most probably be minor, so I
guess it is as perfect as it gets.

I've also reviewed and re-reviewed the installer localization files.

Any idea on when this may land in CVS? If it is still possible to have an
official pt-PT localization for Firefox I would like to know if it will happen
soon, so that I can decide whether or not to do a "Community Edition" langpack.

Comment 14

[Carlos Rodrigues]

Attachment: toolkit localization for pt-PT (2)

Comment 15

[Carlos Rodrigues]

Attachment: Phishing protection fix

There was a problem with some strings that caused some phishing-protection
related dialogs to not appear. This patch fixes it (and also fixes some
non-escaped quotes that were around).

Comment 16

[Carlos Rodrigues]

Hello? Anybody out there?

Comment 17

[Benjamin Smedberg]

Gandalf, can you review?

Comment 18

[Zibi Braniecki [:zbraniecki][:gandalf]]

sure.

Comment 19

[Zibi Braniecki [:zbraniecki][:gandalf]]

Sorry for taking so long.

1) ./browser/extra-jars.mn must contain all files from help (example
http://lxr.mozilla.org/l10n-aviarybranch/source/browser/locales/pl-PL/extra-jar.mn)
2) ./browser/chrome/browser/credits.dtd - you have too much credit.translation
entities there
3) A few files have windows like line endings (example
./toolkit/chrome/global/intl.css)

Comment 20

[Carlos Rodrigues]

Ok, I'll make the proper fixes and attach a patch here, later in the day.

BTW, the windows line endings thing is weird, since I've never even touched
intl.css, AFAIK. But maybe it was a problem with Mozilla Translator (which I
don't use anymore). Anyway, I'll just dos2unix every .properties, .dtd and .css
file.

Comment 21

[Carlos Rodrigues]

Attachment: fix CRLFs, extra-jar.mn, credits.dtd

Ok, I fixed those 3 issues. (This patch also changes one or two unimportant,
but erroneous, strings I found meanwhile).

Comment 22

[Carlos Rodrigues]

Attachment: fix CRLFs, extra-jar.mn, credits.dtd (for real)

Oops... I attached the wrong file... (it was my test langpack, BTW).

Comment 23

[Carlos Rodrigues]

It would be nice to have this thing going before it gets obsoleted by Firefox
1.1's launch... Or else just say you're not interested.

I posted the first zips here almost 2 months ago...

Comment 24

[Benjamin Smedberg]

I'll vouch, even if gandalf hasn't re-reviewed the latest set of ZIPs.
Marcia/myk, I think this one is ready.

Comment 25

[Zibi Braniecki [:zbraniecki][:gandalf]]

I re-reviewed it, and told on #l10n that I'm fine with them. 
Sorry for not commenting it in bug.

Comment 26

[Marcia Knous [:marcia]]

assigning to my per commment 24

Comment 27

[Carlos Rodrigues]

Where/when can I expect some test builds to pop up?

Comment 28

[Myk Melez [:myk] [@mykmelez]]

Ok, your account has been created.  Your username is the email listed in the
summary of this bug, with % in place of @.

Comment 29

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I suspect builds will show up once it's:
 * checked in
 * added to the toolkit/locales/all-locales and browser/locales/all-locales
files (might want to check with bsmedberg on how this needs to be done and tagged)

Comment 30

[Benjamin Smedberg]

Pike/gandalf, can one of you commit the attached files on the branch?

Comment 31

[Zibi Braniecki [:zbraniecki][:gandalf]]

Checked in on 02:15 am CET.

Comment 32

[Carlos Rodrigues]

Cool. :)

So, now I have to wait for the builds to show up, test them and give a green
light if they are ok, right?

And I have some more questions...
 - what is the right place to give that "green light"?
 - if I have to commit changes, do I have to open a bug report and ask for
approval? I mainly ask this because I have some minor changes to the
now-commited localization, that would be nice to submit before a pt-PT build is
launched (the localization is ok as-is, so it wouldn't make much difference if
those changes have to wait for 1.1, though).
 - will the builds show up somewhere around here? ->
ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/

Comment 33

[Carlos Rodrigues]

I would very much like my previous questions answered, because I would like to
see a pt-PT Firefox 1.1 (as it seems it is out of the question for 1.0).

I mainly ask:

1) Can I commit anything to the repository?
2) What is it needed to have some pt-PT test builds?
3) What is the process to green light a build?

Without knowing the above, I won't just go and commit stuff (I don't want to
break any rules). And as it currently stands, my prospects for a 1.1 pt-PT
Firefox seem bleak (this stuff seems to move so slow as to be completely halted,
I'm starting to remember why I looked at all this localization-in-cvs stuff with
a truck load of suspicion...).

Comment 34

[Benjamin Smedberg]

Hrm, it seems this should have been added to all-locales on the branch/release
tag. Pike? Carlos, this should produce test builds of Firefox 1.0 and the 1.0.1
which should be coming out at some point soon.

Carlos, you have permission to commit files to the trunk for Firefox 1.1
following the instructions posted at
http://benjamin.smedbergs.us/l10n/trunk-l10n.html  We don't have test builds set
up yet, but hope to soon.