263769 - Tab-switching shortcuts (next/previous tab) use Ctrl, not Cmd on Mac

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Russ]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3) Gecko/20041009 Firefox/0.10
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3) Gecko/20041009 Firefox/0.10

These Keyboard Shortcuts are listed in Help documentation as having Cmd+
combinations, but are actually Ctrl+ Combinations.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Steffen Wilberg]

event.ctrlKey is used here:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/content/widgets/tabbox.xml&rev=1.10.14.4&mark=122-147#122

Reporter, do Opera and IE for Mac use Ctrl as well?

Comment 2

[Russ]

(In reply to comment #1)
> event.ctrlKey is used here:
> http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/content/widgets/
tabbox.xml&rev=1.10.14.4&mark=122-147#122
> 
> Reporter, do Opera and IE for Mac use Ctrl as well?

In general Cmd on the Mac is the equivalent to Ctrl on the PC, however Cmd+Tab is already reserved by 
OS X as the Alt+Tab equivalent to switch programs.  IE 5.2 Mac doesn't support Tabs, and I'm not sure 
how Opera handles this, but Safari uses Shift+Cmd+Right and Shift+Cmd+Left.  I think Ctrl+Tab and 
Shift+Ctrl+Tab are appropriate, but just need to keep the Help in sync.

Comment 3

[Steffen Wilberg]

Argh, IE is not relevant here of course.

So Opera can't use Cmd+Tab. The question remains if it uses Ctrl+Tab or Alt+Tab.
Also, does it use Cmd+F6, Ctrl+F6, or Alt+F6? 

http://www.opera.com/features/keyboard/index.dml?platform=mac doesn't list these
shortcuts. I'd appreciate it a lot if you could grab Opera and test it!

Comment 4

[Jeff Walden (gone starting June 8)]

Nice catch, and now fixed on branch and trunk (the Firefox shortcut, that is). 
I also changed the entity for the Ctrl key to be &ctrlKey;, which makes more
sense when it's known as ''event.ctrlKey' in the DOM.  (Steffen, I grabbed this
before you made the changes to the bug -- I was going to mark it fixed when I
got the mid-air collision report.)

Anyways, currently most of the shortcuts listed in Help should be okay on the
Mac, but there might be a few wrong ones hanging around (as fallout from bug
259883).  If you find others, report them here.

For now, I'm leaving this open so we can confirm the shortcuts for Opera (and
also for other wrong shortcuts, should they exist).

Comment 5

[Russ]

I checked and it is Opt+Tab on Opera.  Also regarding other issues in Help, this is the only inconsistent 
one, however I have separately submitted about 10 other bugs for shortcut keys that are not 
currently working.

Comment 6

[Steffen Wilberg]

I just fixed the Opera shortcut as well. Thanks for your help, Russ!

Comment 7

[Russ]

I'm using the latest nightly build:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a5) Gecko/20041015 Firefox/0.9.1+

Help has been updated, but now the Ctrl+Tab and Ctrl+Shift+Tab Keyboard Shortcuts have stopped 
working.

I'm reopening this bug and assigning it to Keyboard Navigation.

Comment 8

[Steffen Wilberg]

> I'm using the latest nightly build:
> Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a5)
Gecko/20041015 Firefox/0.9.1+
That's a trunk build (corresponding Mozilla version is 1.8a5). Please try the
latest avaiary branch build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-0.9/firefox-1.0.en-US.mac.dmg.gz
 
> I'm reopening this bug and assigning it to Keyboard Navigation.
Please don't. File a new bug in the Keyboard Navigation component, trunk version.

-> back to Help Doc.

Comment 9

[Steffen Wilberg]

Resolving again.

Comment 10

[Russ]

(In reply to comment #8)
Sorry, wasn't sure of the process.