264064 - Lose secure site indicators when customizing toolbars

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Richard Klein]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041011 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041011 Firefox/0.10.1

If the toolbar is customized while on a secure website, the lock icon, location
bar coloring, and host name are lost from the display.

Reproducible: Always
Steps to Reproduce:
1.  go to any secure website.
2.  right click on toolbar and select customize.
3.  add any item to toolbar, or remove any item from toolbars.
4.  click done.

Actual Results:  
All secure site information is removed from view.

Expected Results:  
Secure information should remain on the display.

Comment 1

[Richard Klein]

Requesting blocking aviary 1.0

Comment 2

[Richard Klein]

Didn't get blocking request put on for some reason.

Comment 3

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041012
Firefox/0.10

Confirming

->NEW

in furter detail
1.Customise
2.all location bar text content disappears, color remains yellow
3.drag something off a toolbar
4,press done
5.locationbar only contains url name+favicon, sec icon and yellow are gone

Comment 4

[Richard Klein]

Attachment: Fix v 1.0

This fixes the lose of the security indicators when customizing toolbar on a
secure site.  The reason the indicators are lost is because the init function
of the statushandler is called when the toolbar changes.  My fix changes the
init function to try and get the security information off the securityui if
available.

Comment 5

[Richard Klein]

Comment on attachment 162728 [details] [diff] [review]
Fix v 1.0

Requesting review

Comment 6

[Kevin Brosnan]

*** Bug 274233 has been marked as a duplicate of this bug. ***

Comment 7

[Richard Klein]

Blocking 1.1?

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 162728 [details] [diff] [review]
Fix v 1.0

the if/else statement is unnecessary here, securityUI should already be inited
in the browser constructor, and is expected to not fail.  We assume so already
elsewhere.  See bug 180962

I'll r+ a patch that just has the required two lines changed.

Comment 9

[Richard Klein]

Attachment: Version 2.0

Remove if statement

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 183078 [details] [diff] [review]
Version 2.0

a=asa

Comment 11

[Asaf Romano (gone)]

Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.423; previous revision: 1.422
done