264385 - error when deleting and then adding folder or bookmark on bookmarks toolbar

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Daniel Lindkvist]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041014 Firefox/0.10 (gorgias)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041014 Firefox/0.10

Deleting an item in bookmarks toolbar leads to a javascript error when trying to
add a new item.

Error: [Exception... "Component returned failure code: 0x80070057
(NS_ERROR_ILLEGAL_VALUE) [nsIRDFContainer.InsertElementAt]"  nsresult:
"0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
chrome://browser/content/bookmarks/bookmarks.js :: anonymous :: line 1677" 
data: no]
Source File: chrome://browser/content/bookmarks/bookmarks.js
Line: 1677

Reproducible: Always
Steps to Reproduce:
1. rightclick bookmarks toolbar and create a new folder/bookmark
2. rightclick the new item and delete that
3. repeat step 1 -> no new item can be added
4. rightclick an existing folder and try to create a new folder there result:
js-error

Actual Results:  
No new item can be added.

Expected Results:  
A new item should be added to the bookmarks toolbar.

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041014
Firefox/0.10
1. add folder to bookmarks toolbar (via rightclick in BM toolbar)
2. rightclick on the folder and walk through the menu
3. watch the behaviour on "new folder" and paste.

rightclick add a folder or bookmark does nothing after the initial folder was
created, but I'm not seeing the error in JSC

Via BM all works well

Comment 2

[Jim Ginn]

I am seeing this in the Bookmark Manager as well.

1) File -> New Bookmark...
2) Hit Cancel
3) File -> New Bookmark...
4) Nothing happens

In js console:

Error: [Exception... "Component returned failure code: 0x80070057
(NS_ERROR_ILLEGAL_VALUE) [nsIRDFContainer.InsertElementAt]"  nsresult:
"0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
chrome://browser/content/bookmarks/bookmarks.js :: anonymous :: line 1677" 
data: no]
Source File: chrome://browser/content/bookmarks/bookmarks.js
Line: 1677

and

Error: [Exception... "Component returned failure code: 0x80070057
(NS_ERROR_ILLEGAL_VALUE) [nsITransactionManager.doTransaction]"  nsresult:
"0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
chrome://browser/content/bookmarks/bookmarks.js :: anonymous :: line 1403" 
data: no]
Source File: chrome://browser/content/bookmarks/bookmarks.js
Line: 1403

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: 264385-bookmarks-bandaid-0.patch

This is a bandaid.  It avoids the broken case described in the bug, but
bookmarks are going to be inserted in odd places.

The fundamental issue is that RDF containers absolutely suck for this sort of
thing; we're basically getting bit because the numbering ends up highly
inconsistent, and beyond a certain point we can't trust GetCount() at all.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 162133 [details] [diff] [review]
264385-bookmarks-bandaid-0.patch

r+a=[e-mail]

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Bandaid is in on aviary, real patch in progress.

Comment 6

[Asa Dotzler [:asa]]

This bug seems to have an aviary branch checkin associated with it. If this has
landed on the aviary branch (as much as it's going to for 1.0) can you please
add the "fixed-aviary1.0" keyword? Thanks.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

The patch isn't a fix, it actually introduces the problem described in this bug
(but fixes worse bugs in the process).

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Er, that comment was intended for bug 264571; this one doesn't exist any more,
for better or worse.

Comment 9

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change