264716 - For some sites the popup warning Option doesn't list the popup that was blocked

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Kevin Brice]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10.1

I would like to be able to see the last popup that was blocked, because in some
rare instances, there is a need to see a popup without wanting to actually allow
the whole site to spawn popups.  This is a very useful feature that can be found
in the IE SP-2 and MSN.  MSN goes even further and shows thumbnails of the
blocked popup, which I have found to be very useful.

Reproducible: Always
Steps to Reproduce:
1.  Have a popup blocked.
Actual Results:  
There is no way to see the popup after it has been blocked.

Expected Results:  
It should give some way to let you see the last popup that was blocked.

Comment 1

[Nickolay_Ponomarev]

There is a way. Just right-click the "popup blocked" icon/toolbar.

Comment 2

[Kevin Brice]

For some reason, that doesn't work for me.  When I right-click the Popup blocked
toolbar, Firefox doesn't do anything.  If I left-click it, it just gives me the
option to accept all popups from the site.

Comment 3

[Nickolay_Ponomarev]

My bad, you should left-click it. In the popup menu that opens I see "open
<location>" items.

example URL?

Comment 4

[Kevin Brice]

Well, an example I just found is that if you refresh www.netscape.com, the bar 
comes up, but when you click it, Firefox will not show you the blocked popup - 
it just offers to allow netscape.com to spawn popups.  This is not an example 
of when you'd need to see a popup, as Netscape's popups are garbage -- just an 
example I found.

Comment 5

[Nickolay_Ponomarev]

I can reproduce the problem with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.7.3) Gecko/20041022 Firefox/1.0

1. Go to http://www.netscape.com/
2. Wait for the page to load, hit F5

Actual: blocked popup notification shows. When you click it, there's no option
to show the popup recently blocked.
Expected: an item in notification's context menu that opens the blocked popup,
as with other popups.

It's just netscape.com for me, and I'm unable to make a testcase. Care to make a
testcase yourself or to list other URLs you're experiencing this bug on?

Comment 6

[Michael Carman]

I've been seeing this behavior reliably on Sprint's website. I've occasionally
seen it elsewhere, too.

1. Go to www.sprintpcs.com
2. Click on "Shopping"

Alternately, try going directly to
    http://www1.sprintpcs.com/explore/ExploreHome.jsp

I get the "Firefox prevented this site..." message but without an option to open
the blocked popup. What's weirder is that if I whitelist the site, I don't get
any popups! I suspect that the message is a "false positive" -- for some reason
Firefox thinks that it blocked a popup but really didn't, and that's why there's
no option to open the blocked popup.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Comment 7

[Juanjo]

Popup blocker only allows "show" one blocked popup.

Also happens on Linux (Debian Sarge), W98 and W2k.
FireFox 1.0.4 (last at this moment) and previous.

Extended explain:
Popup blocker blocks a popup.
Popup-blocked icon blooms in the status bar.
Click on this icon -> show "URL".
Popup opens :-)

But since then, sucesive clicks on popup-blocked icon are completely ignored.
No other blocked-popup can be "shown".

Comment 8

[Trevan]

I would like this same feature.  I was on slashdot, and there was an ad at the
top (in flash) for alienware.  I decided to click on it and go there.  I got the
popup blocking dialog, and no way to get the specific page.  Right clicking or
left clicking didn't give anything and preferences only lets me whitelist the
page.  I then tried to see if I can duplicate it, and so refreshed slashdot
until another flash ad at the top appeared (this time for newegg.com).  Same
thing happened.  So at least my problem is with the flash popup blocker.

Comment 9

[Joe Hughes]

*** Bug 270800 has been marked as a duplicate of this bug. ***

Comment 10

[:Gavin Sharp [email: [e-mail]]]

So is "'Show popup' in the popup information bar sometimes doesn't appear" a better summary for this bug?

Comment 11

[Joe Hughes]

I was just in the process of editing the title

What appears to be happening is that the pageReport isn't giving the popup blocking message any useful popup URIs to put in the menu.  (I don't know why this is the case yet, but Ben had left a note in the code about frames, so maybe it's related.)  Useless popup URIs are filtered out of the menu--to see the relevant code, look for "pageReport.length" in browser.js.

I'll post a patch soon that removes the spurious separator in this case.

Comment 12

[Joe Hughes]

Attachment: Adds some comments to the relevant code, and avoids showing spurious separator when we don't have any popup instances to show in the menu

I haven't tracked down the root cause of this problem, but this patch annotates the situation and makes the menu a little prettier in the meantime. :]

Comment 13

[Joe Hughes]

Bug 235450 seems to have some relevant discussion of how we get into this situation.  Bug 282515 has more example URIs.

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 216278 [details] [diff] [review]
Adds some comments to the relevant code, and avoids showing spurious separator when we don't have any popup instances to show in the menu

sr=[e-mail]

Comment 15

[Joe Hughes]

OK, I landed that one patch on 1.8 branch and trunk, so at least we won't have the spurious separator.  (This doesn't solve the problem of not being able to show the popup(s), though.)

Comment 16

[Mike Connor [:mconnor]]

This is a nice-to-have, but doesn't seem to be all that common.  Would be good to get information on why this happens so we can scope a possible fix.

Comment 17

[Phil Ringnalda (:philor)]

*** Bug 343072 has been marked as a duplicate of this bug. ***

Comment 18

[Tracy Walker [:tracy]]

mconnor, bug 343772 was plus for 2.0.  I believe this is related to that bug.  I'm requesting blocking Firefox2 for that reason.

I'm changing the given test URL. That site no longer appears to be serving up popups. cnn.com initially will serve up a popup.  (remove cnn.com cookies to reliably reproduce)

This may be happening for reasons related to popups in frame/iframe documents. See bug 343772

- load cnn.com,  Open the blocked popup Options (Preferences) button. Notice that the blocked popup is not listed.

Comment 19

[Mike Beltzner [:beltzner, not reading bugmail]]

This would be a new feature, and we can't start taking those at this time.

Comment 20

[Tracy Walker [:tracy]]

Attachment: Popup blocked without showing the popupURL

Comment 21

[Tracy Walker [:tracy]]

Attachment: popup blocked showing url

reload cnn until the popup is blocked and shown in the Options button list as expected.

Comment 22

[Tracy Walker [:tracy]]

Is showing the URL of the popup in the first case a new feature that's different from showing the URL in the second case?

Comment 23

[Tracy Walker [:tracy]]

reread this entirely.  The original request to be able to open a blocked popup was fixed long ago.  The options button will show you a list of block popups which you can click on and the popup will appear. This bug began morphing into the lack of listed blocked popups in march '06.  Disregard the summary, it doesn't match the original bug report.

I am going to mark this WFM and open a new bug for the more recent issue.

Comment 24

[Tracy Walker [:tracy]]

filed bug 347369 for the popup missing from blocked popup list.