264830 - If keyword.URL doesn't lead to a redirect, resulting page has bogus "keyword:" URL

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Jesse Ruderman]

(Split from bug 254040, see bug 254040 comment 25.)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041016 Firefox/1.0

Steps to reproduce:
1. Set keyword.URL to http://www.google.com/search?ie=UTF-8&q=
(See http://www.squarefree.com/archives/000570.html)
2. Restart Firefox (bug 259979).
3. Type "foo" into the address bar and press Enter.

Result: Address bar shows "keyword:foo".
Expected: Address bar should show "http://www.google.com/search?ie=UTF-8&q=foo".

This isn't a bug in the address bar, but rather in the implementation of the
keyword: protocol.  Page Info shows the keyword: URL too, and it breaks the
Search Keys extension.

Comment 1

[Martin Dickson]

Version: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050201
Firefox/1.0+

Additional odd behaviour when two search terms used:
1) As above, set keyword.URL to http://www.google.com/search?ie=UTF-8&q=
2) Restart Firefox
3) Type "foo weasel" into the address bar and press Enter.
4) Results appear, address bar shows "keyword:foo weasel".
5) Attempt to right-click, "Open Link in New Window", or right-click, "Open
Window in New Tab", or center-click (if this is bound to open in new tab) on a
result link.
6) Left-click on a result link.

Result: right and center clicks have no effect. Left click still operates correctly.
Expected result: All options should operate normally.

If you then click on the Google search button (near the top of the results
page), the same page redisplays, but with the correct URL. Right and center
clicks now work.

The source for both pages appears identical; the only visible difference being
the URL.

Comment 2

[tyl2]

I think this behavior is new in 1.5RC3 or thereabout, and as a matter of fact, I like it. I like to search from the location bar and this makes it easier to modify search strings. For example, if I search for "beanie baby" and find too many results of babies of a species called beanies, I'll want to search for "beanie baby bears" instead. Before, I'd have to use my mouse to navigate to the search box on the Google search results page, but now I can just Alt+D then Ctrl+End to move the cursor to the right place. I love it.

Comment 3

[Jesse Ruderman]

Version 0.7.2 of Search Keys includes a workaround for this bug.  It now checks document.documentURI instead of document.location.href to determine which search engine (if any) you're using.

Comment 4

[Jesse Ruderman]

See also bug 337339, a recent regression: "Keyword search pages containing relative urls appear broken".

Comment 5

[Jesse Ruderman]

This was fixed in bug 337339, right?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Er, yes.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Fixed on the branch in bug 337339.