Closed Bug 264868 Opened 20 years ago Closed 20 years ago

Use .login and .email correctly when 'emailsuffix' is used

Categories

(Bugzilla :: Creating/Changing Bugs, defect)

Product:
Bugzilla
Component:
Creating/Changing Bugs
Version:
2.18
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.18

People

(Reporter: andreas.beckmann, Assigned: Wurblzap)

References

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

Fixing other places, too [head patch]
2.97 KB, patch
goobix
: review+
Details | Diff | Splinter Review
Fixing other places, too [branch patch]
3.10 KB, patch
goobix
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040917 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040917 Firefox/0.9.3

I'm running an installation of bugzilla which uses the 'emailsuffix' parameter
to add '@doma.in' to the logins.
After a recent bugzilla upgrade (2.18rc1/CVS (?) to 2.18rc2/CVS) Bugzilla
started to reassign bugs on commenting and complained about failed matches.
This happens because the 'Reassign To' field contains the complete email
address, not just the login part.

RFE: if matching fails, try stripping 'emailsuffix' from the failed login.

Reproducible: Always
Steps to Reproduce:
Attachment #162460 - Attachment description: use 'bug.assigned_to.login' instead of 'bug.assigned_to.login' in template/en/default/bug/knob.html.tmpl → use 'bug.assigned_to.login' instead of 'bug.assigned_to.email' in template/en/default/bug/knob.html.tmpl
Version: unspecified → 2.18
This is a regression of bug 255913.
Flags: blocking2.20?
Flags: blocking2.18?
Comment on attachment 162460 [details] [diff] [review]
use 'bug.assigned_to.login' instead of 'bug.assigned_to.email' in template/en/default/bug/knob.html.tmpl

> use 'bug.assigned_to.login' instead of 'bug.assigned_to.login' in

This should be: Use  .login rather than .email

Looks sensible.
r=burnus
Attachment #162460 - Flags: review+
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: approval?
Bug 255913 went into 2.18, too.
Flags: blocking2.20?
Flags: blocking2.18?
Flags: approval2.18?
Flags: approval?
Flags: approval2.18?
Flags: approval2.18+
Flags: approval+
Keywords: regression
Target Milestone: --- → Bugzilla 2.18
Assignee: myk → andreas.beckmann
Previous patch, plus two more places.

I obviously missed this class of e-mail occurrences in bug 255913. Now Andreas'
bug made me aware of it, I re-checked with it in mind. I identified two similar
places I should have fixed in bug 255913.
Attachment #162563 - Flags: review?
clearing approvals until we get new reviews
Flags: approval2.18+
Flags: approval+
Attachment #162564 - Flags: review?
These look correct but I am currently unable to test, please request testing
from someone more active.
Flags: blocking2.20?
Flags: blocking2.18?
This bug blocks bug 157567. A quick review would be fine! :)
Blocks: 157567
Comment on attachment 162563 [details] [diff] [review]
Fixing other places, too [head patch]

vladd, kiko told me you were the right person to ask. :)
Attachment #162563 - Flags: review? → review?(vladd)
Attachment #162460 - Attachment is obsolete: true
Flags: blocking2.18? → blocking2.18+
Flags: blocking2.18+ → blocking2.18?
Assignee: andreas.beckmann → wurblzap
the branch patch fixed the issue for me on 2.18rc3.
Flags: blocking2.20?
Flags: blocking2.20+
Flags: blocking2.18?
Flags: blocking2.18+
Comment on attachment 162563 [details] [diff] [review]
Fixing other places, too [head patch]

r=vladd assuming someone tested this.
Attachment #162563 - Flags: review?(vladd) → review+
Comment on attachment 162564 [details] [diff] [review]
Fixing other places, too [branch patch]

r=vladd assuming someone tested this.
Attachment #162564 - Flags: review? → review+
Flags: approval2.18+
Flags: approval+
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
 edit.html.tmpl
new revision: 1.45; previous revision: 1.44
done
Checking in template/en/default/bug/knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/knob.html.tmpl,v  <--
 knob.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/global/confirm-user-match.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/confirm-user-match.html.tmpl,v
 <--  confirm-user-match.html.tmpl
new revision: 1.8; previous revision: 1.7
done

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
 edit.html.tmpl
new revision: 1.40.2.3; previous revision: 1.40.2.2
done
Checking in template/en/default/bug/knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/knob.html.tmpl,v  <--
 knob.html.tmpl
new revision: 1.6.2.1; previous revision: 1.6
done
Checking in template/en/default/global/confirm-user-match.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/confirm-user-match.html.tmpl,v
 <--  confirm-user-match.html.tmpl
new revision: 1.7.2.1; previous revision: 1.7
done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Summary: show_bug.cgi should honour 'emailsuffix' in 'Reassign bug to' field → Use .login and .email correctly when 'emailsuffix' is used
*** Bug 276839 has been marked as a duplicate of this bug. ***
Blocks: 278473
*** Bug 278473 has been marked as a duplicate of this bug. ***
No longer blocks: 278473
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: