264868 - Use .login and .email correctly when 'emailsuffix' is used

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Andreas Beckmann]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040917 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040917 Firefox/0.9.3

I'm running an installation of bugzilla which uses the 'emailsuffix' parameter
to add '@doma.in' to the logins.
After a recent bugzilla upgrade (2.18rc1/CVS (?) to 2.18rc2/CVS) Bugzilla
started to reassign bugs on commenting and complained about failed matches.
This happens because the 'Reassign To' field contains the complete email
address, not just the login part.

RFE: if matching fails, try stripping 'emailsuffix' from the failed login.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Andreas Beckmann]

Attachment: use 'bug.assigned_to.login' instead of 'bug.assigned_to.email' in template/en/default/bug/knob.html.tmpl

Comment 2

[Marc Schumann [:Wurblzap]]

This is a regression of bug 255913.

Comment 3

[Tobias Burnus]

Comment on attachment 162460 [details] [diff] [review]
use 'bug.assigned_to.login' instead of 'bug.assigned_to.email' in template/en/default/bug/knob.html.tmpl

> use 'bug.assigned_to.login' instead of 'bug.assigned_to.login' in

This should be: Use  .login rather than .email

Looks sensible.
r=burnus

Comment 4

[Marc Schumann [:Wurblzap]]

Bug 255913 went into 2.18, too.

Comment 5

[Marc Schumann [:Wurblzap]]

Attachment: Fixing other places, too [head patch]

Previous patch, plus two more places.

I obviously missed this class of e-mail occurrences in bug 255913. Now Andreas'
bug made me aware of it, I re-checked with it in mind. I identified two similar
places I should have fixed in bug 255913.

Comment 6

[Marc Schumann [:Wurblzap]]

Attachment: Fixing other places, too [branch patch]

Comment 7

[Dave Miller [:justdave]]

clearing approvals until we get new reviews

Comment 8

[Christian Reis]

These look correct but I am currently unable to test, please request testing
from someone more active.

Comment 9

[Frédéric Buclin]

This bug blocks bug 157567. A quick review would be fine! :)

Comment 10

[Frédéric Buclin]

Comment on attachment 162563 [details] [diff] [review]
Fixing other places, too [head patch]

vladd, kiko told me you were the right person to ask. :)

Comment 11

[Andrew Kitchen]

the branch patch fixed the issue for me on 2.18rc3.

Comment 12

[Vlad Dascalu]

Comment on attachment 162563 [details] [diff] [review]
Fixing other places, too [head patch]

r=vladd assuming someone tested this.

Comment 13

[Vlad Dascalu]

Comment on attachment 162564 [details] [diff] [review]
Fixing other places, too [branch patch]

r=vladd assuming someone tested this.

Comment 14

[Vlad Dascalu]

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
 edit.html.tmpl
new revision: 1.45; previous revision: 1.44
done
Checking in template/en/default/bug/knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/knob.html.tmpl,v  <--
 knob.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/global/confirm-user-match.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/confirm-user-match.html.tmpl,v
 <--  confirm-user-match.html.tmpl
new revision: 1.8; previous revision: 1.7
done

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
 edit.html.tmpl
new revision: 1.40.2.3; previous revision: 1.40.2.2
done
Checking in template/en/default/bug/knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/knob.html.tmpl,v  <--
 knob.html.tmpl
new revision: 1.6.2.1; previous revision: 1.6
done
Checking in template/en/default/global/confirm-user-match.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/confirm-user-match.html.tmpl,v
 <--  confirm-user-match.html.tmpl
new revision: 1.7.2.1; previous revision: 1.7
done

Comment 15

[Muhammad Junaid Shahid]

*** Bug 276839 has been marked as a duplicate of this bug. ***

Comment 16

[Marc Schumann [:Wurblzap]]

*** Bug 278473 has been marked as a duplicate of this bug. ***