264974 - Failure to send email shows as email still being sent

Status: VERIFIED INVALID

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[alanjstr]

The following error was not captured and handled.

Warning: mail() [function.mail]: "sendmail_from" not set in php.ini or custom
"From:" header missing in
D:\cvs-1.11.5\mozilla\webtools\update\developers\mail_newaccount.php on line 32

The following text was still displayed, causing confusion.

Your account has been created successfully. An e-mail has been sent to you with
instructions on how to activate your account so you can begin using it.

The confirmation should only show if there are no errors.

Comment 1

[alanjstr]

The account is still created.

Comment 2

[Wolf [:wolf]]

Having a properly configured PHP isn't Update's issue. It's the responsibility
of the server admin to fix such warnings.

Comment 3

[alanjstr]

The root problem is that you don't gracefully capture php errors.  I'd call it a
security hole if this wasn't open source.

Comment 4

[Wolf [:wolf]]

A PHP warning isn't a security hole. (you could ask sysadmins to change
display_errors to false on the live site if you care that much about warnings
taht the average user can see and file a bug on being hidden.)