265055 - textarea.select() can steal focus from other tabs

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[Jesse Ruderman]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041018 Firefox/1.0

textarea.select() steals focus from other tabs.  (textbox.select() and
textarea.focus() do not.)  This is a security hole because it can cause typed
information to go to a tab other than the selected one.

Comment 1

[Jesse Ruderman]

Attachment: demo

Comment 2

[Johnny Stenback (:jst)]

Attachment: Fix.

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 162732 [details] [diff] [review]
Fix.

This is not quite the same code as what's in nsHTMLInputElement::Select()...
that code calls nsTextControlFrame::SetFocus even if the event was discarded.
We probably want to change that code to be like this code, we don't want a
partial focus.

Comment 4

[chris hofmann]

Comment on attachment 162732 [details] [diff] [review]
Fix.

a=chofmann for the branch

Comment 5

[Johnny Stenback (:jst)]

Fixed on the aviary branch, leaving bug open to track the issue the bryner
pointed out as this gets merged onto the trunk...

Comment 6

[sairuh (rarely reading bugmail)]

using the demo test here, this looks fixed with 2004102109-0.9+ on linux fc2.

Comment 7

[sairuh (rarely reading bugmail)]

also vrfy'd fixed on mac os x 10.3.5, 2004102107-0.9+ bits.

Comment 8

[Tracy Walker [:tracy]]

fixed on Windows too; FF build 2004-10-21-07-0.9

Comment 9

[Jesse Ruderman]

Making public because this bug has the same impact as bug 124750 and because
there hasn't been a hotfix or release since 124750 was fixed.

Comment 10

[Oliver Klee]

Will this be checked in to the 1.7.x branch, too?

Comment 11

[Martijn Wargers (dead)]

You might want to take a look at bug 265456. It describes a method in which you
can still focus a textarea in a background tab, by using createEvent.

Comment 12

[Sven Jost]

Is this the same bug as in bug 138646 only for a different function
(textarea.select not textbox.blur)?

Comment 13

[Mike Kaply [:mkaply]]

Can we get a 1.7 fix for this please?

Comment 14

[Johnny Stenback (:jst)]

Not a firefox specific bug.

Comment 15

[Johnny Stenback (:jst)]

Comment on attachment 162732 [details] [diff] [review]
Fix.

This patch fixes this for SeaMonkey as well. Requesting 1.7.5 approval.

Comment 16

[Mike Kaply [:mkaply]]

Comment on attachment 162732 [details] [diff] [review]
Fix.

a=mkaply for 1.7.5 checkin

Comment 17

[Daniel Veditz [:dveditz]]

Has this landed on the trunk? If so why is it still open?

Comment 18

[Daniel Veditz [:dveditz]]

This was checked into the trunk 2004-11-04